openstack/openstack-ansible-rabbitmq_server - openstack-ansible-rabbitmq_server - OpenDev: Free Software Needs Free Tools

This patch updates the tox.ini the same bashate exceptions as are
currently in the OpenStack-Ansible playbook repo.
It also ensures that the linters and all lint targets work
appropriately and normalises the tox.ini configuration to use
uniform formatting.
The use of ansible.cfg is removed as there is no way of being
certain which paths can be used without reverting to an ugly
sed hack in the commands. This is why it is preferred to make
use of environment variables which make use of tox's default
substitutions instead. It's a more reliable way of achieving
the goal for the purpose of gating and testing.
The switch to using a git clone instead of ansible-galaxy to
download the plugins is due to the path spec not being able to
work in Ansible 2.x. [1]
[1] https://github.com/ansible/ansible/issues/13563
Change-Id: I19d0a88574ca7bcb4d8709e14fbb5ffec5a8d021

OpenStack-Infra has requested that lint tests be pipelined into the 'linters'
tox target in order to make more efficient use of nodepool resources.
This patch:
- Ensures that a complete set of lints tests is available in individual
 tox targets.
- Adds a 'linters' target which executes all the other lints tests.
Change-Id: I98feb85a9a3a530f291c50bc46ec9c639327162a

Change-Id: I1529ef969605dab7ec6adfe23f02a1637d6a9ff0

This changes the test for rabbitmq process checking to use
a command that would actually be useful.
Change-Id: I2b48df8dce4b77c0359ad8f28f544559c3e54f50
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

Currently, the key and cert files are not being distributed to
non-primary nodes. This commit does the following:
- references the primary node in rabbitmq_ssl_key_distribute.yml when
 referencing the key and cert facts
- uses a slurp in rabbitmq_ssl_key_distribute.yml so we can get exact
 copies for the key / cert files (previously the files would get
 created without trailing newlines)
- adds some basic tests to ensure these files are consistent across
 the cluster
- removes unnecessary with_items loops in
 rabbitmq_ssl_key_distribute.yml
Change-Id: I98bcd17dac9a47cc19e0d9ec90176945a6d7e355
Co-Authored-By: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>

Currently the contents of the key file are 'rabbitmq_ssl_key_fact'
instead of the actual key and the same goes for the cert.
This patch ensures that the contents of the file are the actual
contents of the fact, not just the fact name.
Change-Id: I3ce18697fa1d6e25678ec624f4e554ed1ff904d6

This brings our tox.ini files inline with other OpenStack projects.
Change-Id: I6dd5066b6e6649b1e0ffca22c913fdc776fbc042
Depends-On: I376e51824c46f9b5eb4a4cff01aaa176632087dd
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

Instead of launching two separate build jobs in our CI infrastructure,
one for bashate and one for pep8, launch a single one. While the jobs
are short, the setup of the images takes a long time, so this is
friendlier to our CI infrastructure.
Use the pep8 environment as common lint target and merge the bashate job
into it.
This patch also renamed dev-requirements to test-requirements to bring it
into line with all other OpenStack projects.
Change-Id: I19c4d9577ff86325fc87b9c03825f40defeeb273

Change-Id: I68d7daf1fda3d8b5cd538f684e973366a3fd61c8
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>