From 485ee87076cd2df1585a80b52e3e167943b0e009 Mon Sep 17 00:00:00 2001 From: Dmitriy Rabotyagov Date: Thu, 3 Apr 2025 12:16:48 +0200 Subject: [PATCH] Ensure that failures are fatal for upgrade_check Ansible's fail will fail only current host in case of met conditions while continuing play for others. In order to prevent further execution for all hosts in case of unmet conditions, which may further break the cluster, `any_errors_fatal` was added to fail tasks. This will end the play for current batch and cancel further batches. Change-Id: I92f24c77b5fb8a3dd9ed17915d7c725d15f9f21e --- tasks/rabbitmq_upgrade_check.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tasks/rabbitmq_upgrade_check.yml b/tasks/rabbitmq_upgrade_check.yml index 9d550d08..db9fb25b 100644 --- a/tasks/rabbitmq_upgrade_check.yml +++ b/tasks/rabbitmq_upgrade_check.yml @@ -57,6 +57,7 @@ - name: Ensure installed RabbitMQ version is same as expected ansible.builtin.fail: msg: "To install a new major/minor version of RabbitMQ set '-e rabbitmq_upgrade=true'." + any_errors_fatal: true when: - not rabbitmq_upgrade | bool - installed_rabbitmq.rc == 0 @@ -73,6 +74,7 @@ Minimal required version for proceeding with RabbitMQ upgrade to {{ rabbitmq_package_version }} is {{ _minimal_required_version }}. Please, upgrade to the version {{ _minimal_required_version }} before proceeding with further upgrade. Current detected version is {{ installed_rabbitmq.stdout }}. + any_errors_fatal: true vars: _minimal_required_version:>- {{ (_rabbitmq_upgrade_minimal_requirement_mapping | selectattr('target', 'in', rabbitmq_package_version) | first)['requirement'] }} @@ -115,6 +117,7 @@ _rabbitmq_cluster_upgrade_blockers: "{{ _rabbitmq_cluster_health_issues | selectattr('condition', 'true') }}" ansible.builtin.fail: msg: "{{ _rabbitmq_cluster_upgrade_blockers | map(attribute='msg') | join('\n') }}" + any_errors_fatal: true when: - rabbitmq_upgrade | bool - _cluster_state

AltStyle によって変換されたページ (->オリジナル) /