Files
c82787b7c4f630f2a07e4511f1a0e0131c0bb4e4
openstack-ansible-os_nova /CONTRIBUTING.rst
Kevin Carter fdd1c4c689 Convert existing roles into galaxy roles 
This change implements the blueprint to convert all roles and plays into
a more generic setup, following upstream ansible best practices.
Items Changed:
* All tasks have tags.
* All roles use namespaced variables.
* All redundant tasks within a given play and role have been removed.
* All of the repetitive plays have been removed in-favor of a more
 simplistic approach. This change duplicates code within the roles but
 ensures that the roles only ever run within their own scope.
* All roles have been built using an ansible galaxy syntax.
* The `*requirement.txt` files have been reformatted follow upstream
 Openstack practices.
* Dynamically generated inventory is now more organized, this should assist
 anyone who may want or need to dive into the JSON blob that is created.
 In the inventory a properties field is used for items that customize containers
 within the inventory.
* The environment map has been modified to support additional host groups to
 enable the seperation of infrastructure pieces. While the old infra_hosts group
 will still work this change allows for groups to be divided up into seperate
 chunks; eg: deployment of a swift only stack.
* The LXC logic now exists within the plays.
* etc/openstack_deploy/user_variables.yml has all password/token
 variables extracted into the separate file
 etc/openstack_deploy/user_secrets.yml in order to allow seperate
 security settings on that file.
Items Excised:
* All of the roles have had the LXC logic removed from within them which
 should allow roles to be consumed outside of the `os-ansible-deployment`
 reference architecture.
Note:
* the directory rpc_deployment still exists and is presently pointed at plays
 containing a deprecation warning instructing the user to move to the standard
 playbooks directory.
* While all of the rackspace specific components and variables have been removed
 and or were refactored the repository still relies on an upstream mirror of
 Openstack built python files and container images. This upstream mirror is hosted
 at rackspace at "http://rpc-repo.rackspace.com" though this is
 not locked to and or tied to rackspace specific installations. This repository
 contains all of the needed code to create and/or clone your own mirror.
DocImpact
Co-Authored-By: Jesse Pretorius <jesse.pretorius@rackspace.co.uk>
Closes-Bug: #1403676
Implements: blueprint galaxy-roles
Change-Id: I03df3328b7655f0cc9e43ba83b02623d038d214e
2015年02月18日 10:56:25 +00:00

3.0 KiB
Raw Blame History

OpenStack nova

tags

openstack, nova, cloud, ansible

category

*nix

contributor guidelines

Filing Bugs

Bugs should be filed on Launchpad, not GitHub: "https://bugs.launchpad.net/openstack-ansible"

When submitting a bug, or working on a bug, please ensure the following criteria are met:
  • The description clearly states or describes the original problem or root cause of the problem.
  • Include historical information on how the problem was identified.
  • Any relevant logs are included.
  • The provided information should be totally self-contained. External access to web services/sites should not be needed.
  • Steps to reproduce the problem if possible.

Submitting Code

Changes to the project should be submitted for review via the Gerrit tool, following the workflow documented at: "http://docs.openstack.org/infra/manual/developers.html#development-workflow"

Pull requests submitted through GitHub will be ignored and closed without regard.

Extra

Tags:

If it's a bug that needs fixing in a branch in addition to Master, add a '<release>-backport-potential' tag (eg juno-backport-potential). There are predefined tags that will autocomplete.

Status:

Please leave this alone, it should be New till someone triages the issue.

Importance:

Should only be touched if it is a Blocker/Gating issue. If it is, please set to High, and only use Critical if you have found a bug that can take down whole infrastructures.

Style guide

When creating tasks and other roles for use in Ansible please create then using the YAML dictionary format.

Example YAML dictionary format:
 -name: The name of the tasks
 module_name:
 thing1:"some-stuff"
 thing2:"some-other-stuff"
 tags:
 - some-tag
 - some-other-tag
Example NOT in YAML dictionary format:
 -name: The name of the tasks
 module_name: thing1="some-stuff" thing2="some-other-stuff"
 tags:
 - some-tag
 - some-other-tag

Usage of the ">" and "|" operators should be limited to Ansible conditionals and command modules such as the ansible shell module.

Issues

When submitting an issue, or working on an issue please ensure the following criteria are met:
  • The description clearly states or describes the original problem or root cause of the problem.
  • Include historical information on how the problem was identified.
  • Any relevant logs are included.
  • If the issue is a bug that needs fixing in a branch other than Master, add the ‘backport potential’ tag TO THE ISSUE (not the PR).
  • The provided information should be totally self-contained. External access to web services/sites should not be needed.
  • If the issue is needed for a hotfix release, add the 'expedite' label.
  • Steps to reproduce the problem if possible.