openstack/openstack-ansible-os_nova - openstack-ansible-os_nova - OpenDev: Free Software Needs Free Tools

Since ansible-core 2.10 it is recommended to use modules via FQCN
In order to align with recommendation, we perform migration
by applying suggestions made by `ansible-lint --fix=fqcn`
Change-Id: I335f0f1bcdb5e5564ce3f82f44eec7d8c6ab4e0e

In order to reduce divergance with ansible-lint rules, we apply
auto-fixing of violations.
In current patch we replace all kind of truthy variables with
`true` or `false` values to align with recommendations along with
alignment of used quotes.
Change-Id: Ie1737a7f88d783e39492c704bb6805c89a199553

With update of ansible-lint to version >=6.0.0 a lot of new
linters were added, that enabled by default. In order to comply
with linter rules we're applying changes to the role.
With that we also update metdata to reflect current state.
Depends-On: https://review.opendev.org/c/openstack/ansible-role-systemd_service/+/888223
Change-Id: I730ae569f199fc8542a5a61beb149f459465d7e2

Keystone role was never migrated to usage of haproxy-endpoints role
and included task was used instead the whole time.
With that to reduce complexity and to have unified approach, all mention
of the role and handler are removed from the code.
Change-Id: I3693ee3a9a756161324e3a79464f9650fb7a9f1a

CentOS used to have spice-html5 package in epel, but it's not the case
for CentOS 8 or Stream. Thus, we need to install SPICE from git repo
even for distro installs.
Change-Id: If435ba24dbdf12450cead70e0e1eaecc50f46470
Closes-Bug: #1923183 

Tags are working differently with includes vs imports, so we should
respect that and use appropriently.
Change-Id: Iaa029ebb27cec98b51472ce4f127337fb83b8b45

When we were migrating service to uwsgi usage, we clean forgot to
trigger uwsgi restart on service config change.
Change-Id: I850db85234cbdf50e18f355ba39fa14e57081efd

Change-Id: I140b92dc6ccee3023d2a8965af768bd1c6488c5d

For distro package based deployments, install the packaged nova console
proxies and console clients packages instead of git repos.
For debian/ubuntu installs, use the console client packages directly so
that the service configs of console proxy services are managed by OSA.
Change-Id: I27577ea263d38555e73ead078526cff1c3114b5a

Currently the install task fails with:
The conditional check 'nova_get_venv | failed or nova_get_venv | skipped' failed.
This is due to the fact that these registered vars are no longer
present, since https://review.openstack.org/599240 removed them.
Rather than have a seperate task to install the extra package,
we can consolidate it into the common task with the same
conditionals.
Change-Id: I41becf0edc25a4b5ea59cb1559facded32f0bbf9

With the more recent versions of ansible, we should now use
"is" instead of the "|" sign for the tests.
This should fix it.
Change-Id: If3e4366c22e900557e4730a7e8838f55ffe30ecc

This was broken since this include was moved into a subdirectory with
commit 33b2472724.
For all other includes moved with the above commit this was fixed in
commit 6ce3958ed4. But this include was
forgotten.
Change-Id: I3606e47f6eee25c1865b4baf735b21385e066b0d

This removes warnings in Ansible 2.4+.
The patch also removes "static:" arguments which are no longer
used by Ansible.
Change-Id: I6341e694cee527b4bcf46f813c09db9f1bcabb00

The current implementation wipes out the novnc/spice directory
every single time the playbook executes. While it does replace
it afterwards it does not fire a notifier to make the service
restart, resulting in the service failing.
This patch makes the install process idempotent - it will only
wipe out the directory if it does not look the way it is
expected to look. It also fires the notifier to restart services
if the git repo changes.
This should ensure that novnc/spice restart properly on upgrades
and that there are no changes/restarts for the service if the git
SHA or software does not change.
Closes-Bug: #1746523
Change-Id: Ic39f884016a6ba0498110267027783001a087a1c

Based on conversation on an ansible issue[1], I implemented
a LB orchestration role[2] similar to the POC here[3].
This will allow external loadbalancer management roles to hook
into a universal notify listener "Manage LB" to perform before/
after endpoint management actions when the service is being
restarted.
[1]: https://github.com/ansible/ansible/issues/27813
[2]: https://github.com/Logan2211/ansible-haproxy-endpoints
[3]: https://github.com/Logan2211/tmp-ansible-27813
Change-Id: I5aecc26606f41bc6b27fbe9a5f600914a88ff2c7

In order to do a developer mode that allows installation of packages
from local file, which take precedence over the developer_mode
constraints, we need to allow the order of the constraints to be changed.
This patch adds a "pip_install_developer_constraints" var which is used
to set the developer mode constraints. By default this will leave the
same behaviour but will allow additional constraints to be added, or the
developermode constraints file to be overriden altogether.
Change-Id: I9b639cf11f0197c996f9d87210142e898ad46191

This change moves the compute drivers into their own directory which will
isolate the compute execution tasks which will limit the loaded tasks
and ensure we're not excessively skipping tasks.
Change-Id: I67895687906c3ba4cbdc8c3cb6a3b17f07bceee1
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>