openstack/devstack-plugin-ceph - devstack-plugin-ceph - OpenDev: Free Software Needs Free Tools

Switch to openstackdocstheme 2.2.1 and reno 3.1.0 versions. Using
these versions will allow especially:
* Linking from HTML to PDF document
* Allow parallel building of documents
* Fix some rendering problems
Update Sphinx version as well.
Set openstackdocs_auto_version to not auto-version the documents.
Set openstackdocs_auto_name to use 'project' as name.
openstackdocstheme renames some variables, so follow the renames
before the next release removes them. A couple of variables are also
not needed anymore, remove them.
Change pygments_style to 'native' since old theme version always used
'native' and the theme now respects the setting and using 'sphinx' can
lead to some strange rendering.
See also
http://lists.openstack.org/pipermail/openstack-discuss/2020-May/014971.html
Change-Id: I71e78d4ff18b0fd92f16f0917283eddad543250f

Add ussuir and train stable job and remove the rocky
and queens which are EM.
Change-Id: I47406690552fc6f8d6fcc1cc04d94cf285d42037

Implement an old TODO item, but in the other way: instead of
enabling the feature on certain branches, disable it on the old
branches (anything still open - even EM - before queens)
and rely on the default value (True) otherwise.
Change-Id: Id5dedf496b355362031deefab1573d052fc72a66

IPv6 export policy support was added to the Manila
CephFS-via-NFS driver in the Train release. This
devstack plugin is branchless, so we'll need to
check for the relevant branch to setup the ipv6
test harness.
The pre-test and post-test hooks will be deleted soon
when devstack-gate is dropped by manila test jobs
in the Victoria cycle. So this code is temporary
but required to make ceph-via-nfs tests pass
in stable/queens-stein branches.
Change-Id: I91a54a8f72d1d514afbfa769c7e8f2ac21d502dc
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

QA people pointed out that It should be set here, not in the job.
Change-Id: Id925fe667472f7a71ac236aec136dd7b59e43794

The Manila driver is not WIP, it's used in many
production deployments since the Liberty release.
Set the option ENABLE_CEPH_MANILA to True in case,
so that the manila related setup will occur automatically
if manila is enabled in devstack.
Change-Id: Iec66b201fd775125505fd229963f2d0a5e64c8cb
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

This reverts commit c1fc88670c.
Depends-On: https://review.opendev.org/#/c/725812/
Change-Id: Ic58b68d431a7226fdd16b5ac2259aff92c9ecd16

Nova implemented the feature for rescuing the BFV instances.
- https://specs.openstack.org/openstack/nova-specs/specs/ussuri/approved/virt-bfv-instance-rescue.html
It is not working with ceph backend as new tests added in Tempest are failing ceph job
Related-Bug: #1876330
Change-Id: Ie675610a040e9f4c164b51b6b61b2a8094ecd09f

In the master (Victoria cycle), manila's
devstack plugin will handle:
- enabling NFS ports for access from guest VMs
- setting up bgp speaker and peer for routing to
 ipv6 tenant networks
I'll clean this up up entirely when we backport
these changes to older branches of manila.
Depends-On: https://review.opendev.org/#/c/724202/
Depends-On: https://review.opendev.org/#/c/724204/
Change-Id: I1087c562ff753cb764a174130ce1fed21a9c7b12
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Add an extra check to verify that ceph-mon service has started
before trying to retrieve its version.
An already existing function is being used, wait_for_daemon
Since we now guarantee that we are using systemctl, we can use
the is-active feature. If the service is running, the exit code
will be 0.
Also, change the command used to get the mon version. We can use
the ceph version command provided by the new cli instead of using
ceph daemon command which requires more privileges.
Change-Id: I2d4f23721107c4b5cb1c09719c55424eecd0c880
Closes-Bug: #1872855 

Upstart is not being used anymore (last release was Sept 2014)
Doesn't make sense to keep bits for this
Make this plugin compatible only with distros with systemctl
Change-Id: I4fd533985d5bce3e0513c46558763629fb1539fc
Closes-Bug: #1874457 

This patch updates/adds the contributor documentation to follow
the guidelines of the Ussuri cycle community goal[1].
[1] https://governance.openstack.org/tc/goals/selected/ussuri/project-ptl-and-contrib-docs.html
Story: #2007236
Task: #38554
Change-Id: I1b544695dc5cc1c9f2cdd5fc3f686dae94d52aaa

devstack-plugins-ceph does not have the doc infra set
up and no doc publish job.
This is need to add the contributor doc as per the ussuri
community goal.
Change-Id: Ib62c34b52b28b753f7f3046d51492fd8d9fb6193

While the job itself is not currently voting within openstack/nova the
use of the plugin essentially is within the nova-live-migration job.
As such we should really enable voting of this job within this project
with the eventual goal of also enabling it within openstack/nova and
other projects using it.
Change-Id: Id243b92e800e2d6e8b2228fadbd1c72b194bbfb9

devstack-plugin-ceph-tempest is py2 job and not supposed
to run on master gate. devstack-plugin-ceph master gate already
run its py3 version devstack-plugin-ceph-tempest-py3.
We need to keep the devstack-plugin-ceph-tempest definition
for stable branches gate.
Change-Id: I6c512b29a0346db1f92de34b1dbfb56958fa2cad

I5698e451861828a8b1240d046d1610d8d37ca5a2 introduced support for this
test in Stein so enable the compute feature from Stein onwards.
Blueprint: extend-in-use-rbd-volumes
Change-Id: I6b2575b12fdb9636f106b3ca28681e29ad3eb8ac

In change I43de36ab570af40bc837d859568f5428c167f083, we started
installing the 'python3-' variants of the 'python-' packages installed
by the 'ceph-common' package in 'install_ceph_remote'. In that change,
we made the assertion that we didn't need to "both hiding this behind
the 'python3_enabled' function or 'USE_PYTHON3' variable since (a) these
packages can happily coexist, (b) projects should be switching to Python
3 now, and (c) using these would require sourcing additional, otherwise
unnecessary devstack libraries just to use this simple function".
However, this didn't take into account the fact that this plugin is not
versioned. This means *any* job that uses this plugin, including things
like stable/pike, will now attempt to install the 'python3-' packages.
Since the base OS on stable/pike, Xenial (16.04), doesn't actually
provide these 'python3-' variants, the command will always fail.
Start hiding the command behind a 'use_python3' function call. Hopefully
by time we drop Python 2 support here we won't have maintained branches
using Xenial. If we do, we'll need to branch or something like that.
Change-Id: I890a1e673fde212218eff4fcf82f7941b3283e5f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-Bug: #1853280 

Previously, this command would simply install the 'ceph-common' package,
which includes a number of Python dependencies. Unfortunately, these
packages are the 'python-' variants [1] and there doesn't appear to be a
'ceph-common-python3' package or similar to install the 'python3-'
variants. As a result, we need to install the 'python3-' variants
manually to ensure consumers of the plugin (like nova) can switch to
Python 3 in their tests.
We don't bother hiding this behind the 'python3_enabled' function or
'USE_PYTHON3' variable since (a) these packages can happily coexist, (b)
projects should be switching to Python 3 now, and (c) using these would
require sourcing additional, otherwise unnecessary devstack libraries
just to use this simple function.
[1] https://packages.ubuntu.com/bionic/ceph-common
Change-Id: I43de36ab570af40bc837d859568f5428c167f083
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Cleanup of CephFS data and metadata pools for manila was only
being done for external CephFS installs.
Do it whenever manila is enabled.
Change-Id: Iee238f91b04231d1e41774a49615023fe26e56f3

Related-Bug: #1653953
Depends-On: https://review.opendev.org/#/c/668123/
Change-Id: I3e1f9683a28a2e2e67a0327031f0670f33391126

Use devstack's vercmp function instead of
bc for version comparisons.
Change-Id: I6436a6f836ad1ab9594858986bfdb8d6d6dbc392

Change-Id: I293ccf2111e2983465fcd8c12b3ea931ad446344

We should be using "ceph fs set <fs_name> allow_new_snaps true"
instead of using the mds call
Change-Id: I7a709d49ec4c93b2a06e961ca8ca1414cf4c1918
Closes-Bug: #1838790 

ceph-create-keys was being used to create keys.
This command has been deprecated and it does nothing.
For this reason, keys were not available when starting
daemons and this made the deployment to fail.
This change adds the correct key creation using ceph-authtool.
Change-Id: Ie1a41f67bbf1c7a58e89168b0c8ad63f101648b4
Co-Authored-By: Giulio Fidente <gfidente@redhat.com>

Depends-on: https://review.opendev.org/#/c/671134/
Depends-on: https://review.opendev.org/#/c/670510/
Change-Id: Ib812d2b960b1375129c7ff74c63c1acd2649102f

devstack-plugin-ceph is branchless and its jobs run on
stable branches. To tests the devstack-plugin-ceph changes
for stable branches, let' add the stable version of
devstack-plugin-ceph-tempest-py3 job in experimental pipeline.
Adding in experimental pipeline as we do not really have to run
those all the time on check gate but can be run on demand.
Change-Id: I9010f0d6226304537adcbe4e3f97250c754a7de9

Related-Bug: #1653953
Depends-On: https://review.opendev.org/#/c/668119/
Change-Id: I1aa87fc16a37b6051e55c35ae69ef911a87d4c11

Related-Bug: #1653953
Depends-On: https://review.opendev.org/668118/
Change-Id: I132e26486782918d31a9ac10332f2802342883a9

The dependent nova fix resolves the issue with rbd and
shelve/unshelve testing in tempest. Re-enabling the test
needs to be branch-specific since devstack-plugin-ceph
is branch-less but the fixes in nova will be branch
specific so we don't want to enable this on any nova
branch that does not have the fix since it would break
the job on those branches.
Related-Bug: #1653953
Depends-On: https://review.opendev.org/457886/
Co-Authored-By: Matt Riedemann <mriedem.os@gmail.com>
Change-Id: Ifbfc15033020c430a93574f2726b2279c9be130d

This patch adds support for installing, configuring all required
ceph-iscsi related packages and daemons. ceph-iscsi requires kernel
version 4.16 or greater.
To enable set
ENABLE_CEPH_ISCSI=True
Adds new config options
CEPH_ISCSI_TARGET_IQN - the rbd-target-gw iqn to use to export volumes
CEPH_ISCSI_API_HOST - the rbd-target-api ip to use to listen on
CEPH_ISCSI_API_PORT - the rbd-target-api port
CEPH_ISCSI_API_USER - the rbd-target-api user for auth against the api
CEPH_ISCSI_API_PASSWORD - the rbd-target-api password for auth against the api
The following packages are required and their deps
tcmu-runner - this requires kernel version 4.16 and > to work. Ubuntu
doesn't have a prebuilt package for this, so we pull it down and compile it.
rtslib-fb - has a pypi package
configshell-fb - has a pypi package
targetcli-fb - doesn't have a pypi package.
ceph-iscsi - doesn't have a pypi package.
The reference documentaion to setup ceph-iscsi targets and daemons:
http://docs.ceph.com/docs/master/rbd/iscsi-target-cli-manual-install
Change-Id: Idfac4883b9d31e80124b8f2f1cc60dd9ce18c594

The manila CentOS jobs break often, and are not
maintained. Let's move them to experimental
so they don't gate every patch. The other manila
jobs currently provide necessary test coverage
to cephfs-native and cephfs-nfs protocols/drivers.
These jobs also run with python3, and we don't
need to support python3.5 any longer.
Change-Id: Ibb752a1d9aa818dd6862bcbbce4d6b6e366b4800

Allow running api and scenario tests
together in the manila test jobs.
Change-Id: Ifbf998d7c8a27ad22a39f46547d1548c052614d0

Devstack and tempest default to enable ssh validation in
a lot of API tests which can fail intermittently:
 http://status.openstack.org/elastic-recheck/#1808010
Also see bug 1802971.
Since a ceph backend for storage shouldn't really have
any impact on whether or not ssh is going to work in a
tempest run, this change disables it in the
devstack-plugin-ceph-tempest jobs which should make the
job faster and more stable.
Change-Id: Iea948bcc43315286e5c130485728152d4710bfcb

There is really no point in running the tempest.api.network
tests in the devstack-plugin-ceph-tempest job since a ceph
backend shouldn't make any difference to those tests.
This should speed up the job slightly and more importantly
avoid unnecessarily random failures from tests that don't matter
for this setup.
Change-Id: Icf8d776a648b93b232b83fd4493e00b5f76b3ebf

Change-Id: I63c00c728033649be33511a068b52b9f15cfa5d4