openstack/devstack-plugin-ceph - devstack-plugin-ceph - OpenDev: Free Software Needs Free Tools

This patch updates the override-defaults to support
setting the CINDER_DRIVER, CINDER_ENABLED_BACKENDS
and CINDER_ISCSI_HELPER env vars for devstack to
ceph_iscsi if and only if ENABLE_CEPH_ISCSI is True.
This is needed by devstack lib/cinder to automatically
configure and enable ceph_iscsi as a backend.
Depends-On: https://review.opendev.org/#/c/662829/
Change-Id: I3447554343edfb5ec84ea65a521168e6d2831dfa

This isn't required with dnf and can overwrite package downgrades
working around other issues in the underlying OS.
Change-Id: I6940f06c14a0e41d63d632724e85bb790229f307

As Fedora 32 has dropped py2 support we need to switch over to the py3
based el8 RPMs now. Fedora 31 can support both allowing us to switch
while still technically supporting it.
Change-Id: I79f61d61ccb044b6c24b5747b991045edf25679e

I0eab8ad25112511b0c4dd4b7796b4cda821bca8b incorrectly attempted to write
directly to the /etc/repos.d/ directory as the stack user. This isn't
possible even with sudo so use the config-manager command to import
locally written files as the stack user.
Additionally ensure there is no whitespace at the start of each line
within the files.
Change-Id: I2fbc3b7c7df90328954eb4dcee921bd2ae9b2706

Shaman packages are not stable and generates
breakages in our gates quite frequently.
Use packages available in download.ceph.com instead.
Change-Id: I0eab8ad25112511b0c4dd4b7796b4cda821bca8b

We seem to have been requesting the latest build from the Shaman API
provided by Ceph however we did not filter the status to be 'ready'
which meant that we sometimes got 'building' status repositories that
cause the jobs to fail.
This should stabilize jobs a lot more by using only the ready
repositories.
Change-Id: Iff47bbe4954da3ab582a007ba04b3df50ae21cd4

We are using iSCSI protocol to operate the volume, instead of ceph
in that case. The storage protocol ceph is used as Ceph RBD.
Change-Id: I288b08279311991a79fdad25e43a51366de7876d
Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org>

It looks like the default bluestore that came with nautilus
is limiting us to a for-testing size of 10G regardless of what the
actual ceph volume is supposed to be. Try setting it to the size
we want (minus some room for overhead).
Closes-Bug: #1888895
Change-Id: I4e5233df826af6eeddc4e77820958909d4fe7d45

Added mgr "allow *" for manila user
Change-Id: I4a0dfbe4925554adbb40fe3d24e44098589f1a09

Limit ceph iscsi ubuntu support only to Focal. As only Focal has the
required packages and we don't want to install ceph-iscsi from master
source code which is changing all the way is not a good way for CI.
Remove api_host setting, let it be ceph iscsi default setting "::"[1],
Which references to ceph-ansible configuration[2]. This makes
rbd-target-api accessible for both localhost(gwcli) and HOST_IP.
Otherwise iscsi gateway creation will fail in newer version
ceph-iscsi[3].
Change minimum-gateways default to 1 for newer version ceph-iscsi,
otherwise client creation will fail on all-in-one setup[4].
Fix gateway creation failure with error:
"The first gateway defined must be the local machine"
Ceph-iscsi requires gateway name to be FQDN, sometimes hostname is not
the same as FQDN.
Fix stop_ceph_iscsi run twice.
Remove setup_packages_for_iscsi as openstack won't support projects that
require packages installed with git clone.
[1]: https://github.com/ceph/ceph-iscsi/blob/master/ceph_iscsi_config/gateway_setting.py#L174
[2]: https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-iscsi-gw/templates/iscsi-gateway.cfg.j2
[3]: https://github.com/ceph/ceph-iscsi/issues/193
[4]: https://github.com/ceph/ceph-iscsi/issues/195
Change-Id: I215b870c66cc27f10f8a6bf18d93feda477a3970

The use of apt to refresh repos is discouraged and prints the following
warning when used:
WARNING: apt does not have a stable CLI interface. Use with caution in scripts
The use of apt also appears to break on our Xenial based branches where
we enable the Xenial Queens Ubuntu Cloud Archive repos that are
unsigned. When using apt to refresh these repos apt returns a failure,
while apt-get only returns a warning.
This change simply switches to apt-get to avoid the above warning and to
allow the older Xenial based stable branches to continue to work.
Change-Id: Ic534a47fff17d36eb1ef128ad6af70a34ed942c9

We were using Jewel/Luminous. Being a developer tool, we should
be sticking with newer versions.
This patch set also adds the following changes
- Refactor setup_packages_for_manila_on_<distro> functions
- Removes ceph_init call. Seems it lost relevance
- Removes APT repositories setup. We directly use shaman/chacra
packages directly
- Removes RUN_AS env var. It has been a while since Ceph
defaults to ceph user to run all the services. No longer needed.
- Removes sleep calls for services start checks. We use systemctl
checks.
- Adds more debugging logs
- Uses the search API from ceph shaman instead of hardwiring urls
- Adds the jq (JSON processor) dependency
Change-Id: I51c90e592070b99422e692d5e9e97083d93146e8

Change-Id: Ieb04d25e0ce0b061e4e2ac26b36e371bd666eedd
Signed-off-by: Kevin Zhao <kevin.zhao@linaro.org>

Implement an old TODO item, but in the other way: instead of
enabling the feature on certain branches, disable it on the old
branches (anything still open - even EM - before queens)
and rely on the default value (True) otherwise.
Change-Id: Id5dedf496b355362031deefab1573d052fc72a66

QA people pointed out that It should be set here, not in the job.
Change-Id: Id925fe667472f7a71ac236aec136dd7b59e43794

The Manila driver is not WIP, it's used in many
production deployments since the Liberty release.
Set the option ENABLE_CEPH_MANILA to True in case,
so that the manila related setup will occur automatically
if manila is enabled in devstack.
Change-Id: Iec66b201fd775125505fd229963f2d0a5e64c8cb
Signed-off-by: Goutham Pacha Ravi <gouthampravi@gmail.com>

Add an extra check to verify that ceph-mon service has started
before trying to retrieve its version.
An already existing function is being used, wait_for_daemon
Since we now guarantee that we are using systemctl, we can use
the is-active feature. If the service is running, the exit code
will be 0.
Also, change the command used to get the mon version. We can use
the ceph version command provided by the new cli instead of using
ceph daemon command which requires more privileges.
Change-Id: I2d4f23721107c4b5cb1c09719c55424eecd0c880
Closes-Bug: #1872855 

Upstart is not being used anymore (last release was Sept 2014)
Doesn't make sense to keep bits for this
Make this plugin compatible only with distros with systemctl
Change-Id: I4fd533985d5bce3e0513c46558763629fb1539fc
Closes-Bug: #1874457 

I5698e451861828a8b1240d046d1610d8d37ca5a2 introduced support for this
test in Stein so enable the compute feature from Stein onwards.
Blueprint: extend-in-use-rbd-volumes
Change-Id: I6b2575b12fdb9636f106b3ca28681e29ad3eb8ac

In change I43de36ab570af40bc837d859568f5428c167f083, we started
installing the 'python3-' variants of the 'python-' packages installed
by the 'ceph-common' package in 'install_ceph_remote'. In that change,
we made the assertion that we didn't need to "both hiding this behind
the 'python3_enabled' function or 'USE_PYTHON3' variable since (a) these
packages can happily coexist, (b) projects should be switching to Python
3 now, and (c) using these would require sourcing additional, otherwise
unnecessary devstack libraries just to use this simple function".
However, this didn't take into account the fact that this plugin is not
versioned. This means *any* job that uses this plugin, including things
like stable/pike, will now attempt to install the 'python3-' packages.
Since the base OS on stable/pike, Xenial (16.04), doesn't actually
provide these 'python3-' variants, the command will always fail.
Start hiding the command behind a 'use_python3' function call. Hopefully
by time we drop Python 2 support here we won't have maintained branches
using Xenial. If we do, we'll need to branch or something like that.
Change-Id: I890a1e673fde212218eff4fcf82f7941b3283e5f
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
Closes-Bug: #1853280 

Previously, this command would simply install the 'ceph-common' package,
which includes a number of Python dependencies. Unfortunately, these
packages are the 'python-' variants [1] and there doesn't appear to be a
'ceph-common-python3' package or similar to install the 'python3-'
variants. As a result, we need to install the 'python3-' variants
manually to ensure consumers of the plugin (like nova) can switch to
Python 3 in their tests.
We don't bother hiding this behind the 'python3_enabled' function or
'USE_PYTHON3' variable since (a) these packages can happily coexist, (b)
projects should be switching to Python 3 now, and (c) using these would
require sourcing additional, otherwise unnecessary devstack libraries
just to use this simple function.
[1] https://packages.ubuntu.com/bionic/ceph-common
Change-Id: I43de36ab570af40bc837d859568f5428c167f083
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Cleanup of CephFS data and metadata pools for manila was only
being done for external CephFS installs.
Do it whenever manila is enabled.
Change-Id: Iee238f91b04231d1e41774a49615023fe26e56f3

Related-Bug: #1653953
Depends-On: https://review.opendev.org/#/c/668123/
Change-Id: I3e1f9683a28a2e2e67a0327031f0670f33391126

Use devstack's vercmp function instead of
bc for version comparisons.
Change-Id: I6436a6f836ad1ab9594858986bfdb8d6d6dbc392

Change-Id: I293ccf2111e2983465fcd8c12b3ea931ad446344

We should be using "ceph fs set <fs_name> allow_new_snaps true"
instead of using the mds call
Change-Id: I7a709d49ec4c93b2a06e961ca8ca1414cf4c1918
Closes-Bug: #1838790 

ceph-create-keys was being used to create keys.
This command has been deprecated and it does nothing.
For this reason, keys were not available when starting
daemons and this made the deployment to fail.
This change adds the correct key creation using ceph-authtool.
Change-Id: Ie1a41f67bbf1c7a58e89168b0c8ad63f101648b4
Co-Authored-By: Giulio Fidente <gfidente@redhat.com>

Related-Bug: #1653953
Depends-On: https://review.opendev.org/#/c/668119/
Change-Id: I1aa87fc16a37b6051e55c35ae69ef911a87d4c11

Related-Bug: #1653953
Depends-On: https://review.opendev.org/668118/
Change-Id: I132e26486782918d31a9ac10332f2802342883a9

The dependent nova fix resolves the issue with rbd and
shelve/unshelve testing in tempest. Re-enabling the test
needs to be branch-specific since devstack-plugin-ceph
is branch-less but the fixes in nova will be branch
specific so we don't want to enable this on any nova
branch that does not have the fix since it would break
the job on those branches.
Related-Bug: #1653953
Depends-On: https://review.opendev.org/457886/
Co-Authored-By: Matt Riedemann <mriedem.os@gmail.com>
Change-Id: Ifbfc15033020c430a93574f2726b2279c9be130d

This patch adds support for installing, configuring all required
ceph-iscsi related packages and daemons. ceph-iscsi requires kernel
version 4.16 or greater.
To enable set
ENABLE_CEPH_ISCSI=True
Adds new config options
CEPH_ISCSI_TARGET_IQN - the rbd-target-gw iqn to use to export volumes
CEPH_ISCSI_API_HOST - the rbd-target-api ip to use to listen on
CEPH_ISCSI_API_PORT - the rbd-target-api port
CEPH_ISCSI_API_USER - the rbd-target-api user for auth against the api
CEPH_ISCSI_API_PASSWORD - the rbd-target-api password for auth against the api
The following packages are required and their deps
tcmu-runner - this requires kernel version 4.16 and > to work. Ubuntu
doesn't have a prebuilt package for this, so we pull it down and compile it.
rtslib-fb - has a pypi package
configshell-fb - has a pypi package
targetcli-fb - doesn't have a pypi package.
ceph-iscsi - doesn't have a pypi package.
The reference documentaion to setup ceph-iscsi targets and daemons:
http://docs.ceph.com/docs/master/rbd/iscsi-target-cli-manual-install
Change-Id: Idfac4883b9d31e80124b8f2f1cc60dd9ce18c594

Allow running api and scenario tests
together in the manila test jobs.
Change-Id: Ifbf998d7c8a27ad22a39f46547d1548c052614d0

Bring CentOS in line with ubuntu and use luminous rather than
jewel for all manila builds.
Change-Id: Ib0924e42551d25b68ee22ffb9b52caba302ac19c

Change-Id: I82cc5232870a820c4c8a0526eb44de45cd67a369

Builds for ubuntu bionic are working now.
We need newer features not yet packaged for ubuntu bionic
for python3 and ceph volume chmod support.
Change-Id: I20fa99c6f6da7d4042b50020ab0e9f34e7ac2de6

Use python3 compatible tempest test discovery and
install the relevant python3 libraries.
Change-Id: Iabd1952ddaba85316dec5cf60c89122dc3825912

The shaman ceph and ganesha repos for ubuntu bionic are less
stable than those available with the bionic distro itself so
use the latter.
Also refactor the ceph/ganesha repo configuration so that it
is easier to read and maintain, and since bionic does not ship
with knfs installed make the service stop/disable for these
services robust in that case.
Change-Id: If00cc82cfb076c75a11738dcaca372b0cc7a1848

Enable encrypted volume testing.
Change-Id: I96739a3592241aff6326662d15f36b39f1772356

Continue to use the upstream shaman repos for manila so
we can test changes prior to their inclusion in the distro.
Also overwrite /etc/ganesha/ganesha.conf rather than
appending to it since the file now ships with configuration
that breaks ganesha with CephFS FSAL.
Change-Id: I6db16684fcf1e4ad573e25f0475b283cd85dc2c7

Similar to what happened some time ago for the stable/queens branch, we
are now seeing issues again on master after there was a new Paste
release being made a couple of weeks ago. So we need to perform
the same workaround of forcing pip to install PasteDeploy over
the distro version on the master branch.
Change-Id: I3e98a08e78182bdf5ec09b30e31b98435ec29456
Closes-Bug: 1803143