[Python-Dev] [Python-checkins] cpython: Fix #14600. Correct reference handling and naming of ImportError convenience

Wed Apr 18 13:28:49 CEST 2012

On Wed, Apr 18, 2012 at 09:19:03PM +1000, Nick Coghlan <ncoghlan at gmail.com> wrote:
> On Wed, Apr 18, 2012 at 7:57 AM, brian.curtin
> <python-checkins at python.org> wrote:
> > diff --git a/Python/errors.c b/Python/errors.c
> > --- a/Python/errors.c
> > +++ b/Python/errors.c
> > @@ -586,50 +586,43 @@
> > + args = PyTuple_New(1);
> > + if (args == NULL)
> > + return NULL;
> > +
> > + kwargs = PyDict_New();
> > + if (args == NULL)
> > + return NULL;

 Shouldn't the second test be
if (kwargs == NULL)
 ???
Oleg.
-- 
 Oleg Broytman http://phdru.name/ phd at phdru.name
 Programmers don't die, they just GOSUB without RETURN.