[Python-Dev] [Python-checkins] cpython: no one passes NULL here (or should anyway)

Mon Jul 4 04:54:23 CEST 2011

2011年7月3日 Nick Coghlan <ncoghlan at gmail.com>:
> On Mon, Jul 4, 2011 at 8:02 AM, benjamin.peterson
> <python-checkins at python.org> wrote:
>> http://hg.python.org/cpython/rev/bbbeddafeec0
>> changeset:   71160:bbbeddafeec0
>> user:        Benjamin Peterson <benjamin at python.org>
>> date:        Sun Jul 03 17:06:32 2011 -0500
>> summary:
>>  no one passes NULL here (or should anyway)
>>>> files:
>>  Python/ceval.c |  3 ---
>>  1 files changed, 0 insertions(+), 3 deletions(-)
>>>>>> diff --git a/Python/ceval.c b/Python/ceval.c
>> --- a/Python/ceval.c
>> +++ b/Python/ceval.c
>> @@ -1115,9 +1115,6 @@
>>>>  /* Start of code */
>>>> -    if (f == NULL)
>> -        return NULL;
>> -
>> May need to replace that with an assert(f != NULL) to keep static
> analysers happy.

Surely static analyzers don't assume every argument passed in is NULL?
-- 
Regards,
Benjamin