[Python-Dev] r86699 - python/branches/py3k/Lib/zipfile.py

Tue Nov 23 15:59:59 CET 2010

Le mardi 23 novembre 2010 à 08:49 -0600, Benjamin Peterson a écrit :
> 2010年11月23日 Antoine Pitrou <solipsis at pitrou.net>:
> > On 2010年11月22日 22:00:08 -0600
> > Benjamin Peterson <benjamin at python.org> wrote:
> >> 2010年11月22日 Łukasz Langa <lukasz at langa.pl>:
> >> > Wiadomość napisana przez Benjamin Peterson w dniu 2010年11月23日, o godz. 00:47:
> >> >
> >> > No test?
> >> >
> >> >
> >> > The tests were there already, raising ResourceWarnings. After this change,
> >> > they stopped doing that. You may say: now they pass for the first time :)
> >>
> >> It looks like you added new API, though. For that, we would expect new tests.
> >
> > It's an internal API, although ZipExtFile doesn't begin with an
> > underscore.
>> Why is it internal API then?

Because it's for use by ZipFile.open(). The ZipExtFile constructor is
not supposed to be called by the user.
You might instead asked why ZipExtFile isn't called _ZipExtFile instead,
and I have no idea.
Regards
Antoine.