[Python-Dev] Request for patch review

Brett Cannon brett at python.org
Sun Jun 4 01:50:20 CEST 2006


On 6/3/06, Georg Brandl <g.brandl at gmx.net> wrote:
>> Georg Brandl wrote:
> > I've worked on two patches for NeedForSpeed, and would like someone
> > familiar with the areas they touch to review them before I check them
> > in, breaking all the buildbots which aren't broken yet ;)
> >
> > They are:
> >
> > http://python.org/sf/1346214
> > Better dead code elimination for the AST compiler
>> No one wants to look at this? It's not too complicated, I promise.

Well, "wants' is a strong word. =)
Code looks fine (didn't apply it, but looked at the patch file itself). I
would break the detection for 'return' in generators into a separate patch
since it has nothing to do with detection of dead code.
-Brett
> http://python.org/sf/921466
> > Reduce number of open calls on startup GB
>> That's now committed.
>> Georg
>> _______________________________________________
> Python-Dev mailing list
> Python-Dev at python.org
> http://mail.python.org/mailman/listinfo/python-dev
> Unsubscribe:
> http://mail.python.org/mailman/options/python-dev/brett%40python.org
>-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.python.org/pipermail/python-dev/attachments/20060603/eb29f6b9/attachment.html 


More information about the Python-Dev mailing list

AltStyle によって変換されたページ (->オリジナル) /