[Python-Dev] Patch Reviewing

Sat Jan 1 03:19:03 CET 2005

Hello,
just felt a little bored and tried to review a few (no-brainer) patches.
Here are the results:
* Patch #1051395
 Minor fix in Lib/locale.py: Docs say that function _parse_localename
 returns a tuple; but for one codepath it returns a list.
 Patch fixes this by adding tuple(), recommending apply.
* Patch #1046831
 Minor fix in Lib/distutils/sysconfig.py: it defines a function to
 retrieve the Python version but does not use it everywhere; Patch
 fixes this, recommending apply.
* Patch #751031
 Adds recognizing JPEG-EXIF files (produced by digicams) to imghdr.py.
 Recommending apply.
* Patch #712317
 Fixes URL parsing in urlparse for URLs such as http://foo?bar. Splits
 at '?', so assigns 'foo' to netloc and 'bar' to query instead of
 assigning 'foo?bar' to netloc. Recommending apply.
regards,
Reinhold