[Python-Dev] New test failure: test_imaplib.py
Piers Lauder
piers@cs.su.oz.au
2002年3月08日 20:07:32 +1100
On 2002年3月08日 09:12:26 +0100, Tino Lange wrote:
>
> Hi!
>
> Indeed, IMAP4_SSL_PORT is missing in the checked in version.
> But it was in my patch, that I've submitted yesterday?!
> Maybe Piers did the patch just by hand, not by "patch"?
>
> It's mainly the missing IMAP4_SSL_PORT and one "," too much in the
> docstring of IMAP4_SSL_PORT.
> Increasing of version numer is OK, of course - this I forgot :-)
>
> Best regards
>
> Tino
My mistake - I had already installed your original imaplib patch,
and only installed the libimaplib.tex patch from your new upload.
New version now fixed to match the diff below.
Incidentally, I can't get into https://sourceforge.net/account/login.php
but when i can, i'll update the tracker.
> -----------------
> -----------------
>
> These are the differences between my patch and the CVS version at the
> moment:
>
> tino@tinux:~/> diff -c imaplib_tl.py imaplib_cvs.py
> *** imaplib_tl.py Fri Mar 8 09:04:54 2002
> --- imaplib_cvs.py Fri Mar 8 09:03:50 2002
> ***************
> *** 15,23 ****
> # Authentication code contributed by Donn Cave <donn@u.washington.edu>
> June 1998.
> # String method conversion by ESR, February 2001.
> # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au>
> April 2001.
> ! # IMAP4_SSL contributed by Tino Lange <tino.lange@isg.de> March 2002
>
> ! __version__ = "2.50"
>
> import binascii, re, socket, time, random, sys
>
> --- 15,23 ----
> # Authentication code contributed by Donn Cave <donn@u.washington.edu>
> June 1998.
> # String method conversion by ESR, February 2001.
> # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au>
> April 2001.
> ! # IMAP4_SSL contributed by Tino Lange <Tino.Lange@isg.de> March 2002.
>
> ! __version__ = "2.51"
>
> import binascii, re, socket, time, random, sys
>
> ***************
> *** 29,35 ****
> CRLF = '\r\n'
> Debug = 0
> IMAP4_PORT = 143
> - IMAP4_SSL_PORT = 993
> AllowedVersions = ('IMAP4REV1', 'IMAP4') # Most recent first
>
> # Commands
> --- 29,34 ----
> ***************
> *** 983,993 ****
> n -= 1
>
>
> class IMAP4_SSL(IMAP4):
>
> """IMAP4 client class over SSL connection
>
> ! Instantiate with: IMAP4_SSL([host[, port[, keyfile[, certfile]]]])
>
> host - host's name (default: localhost);
> port - port number (default: standard IMAP4 SSL port).
> --- 982,993 ----
> n -= 1
>
>
> +
> class IMAP4_SSL(IMAP4):
>
> """IMAP4 client class over SSL connection
>
> ! Instantiate with: IMAP4_SSL([, host[, port[, keyfile[,
> certfile]]]])
>
> host - host's name (default: localhost);
> port - port number (default: standard IMAP4 SSL port).
> ***************
> *** 1052,1057 ****
> --- 1052,1058 ----
> ssl = <instance>.socket.ssl()
> """
> return self.sslobj
> +
>
>
> class _Authenticator:
> tino@tinux:~/ >