[Python-checkins] bpo-41260: C impl of datetime.date.strftime() takes different keyword arg (GH-21712)

Fri Nov 25 04:21:31 EST 2022

https://github.com/python/cpython/commit/b1dcdefc3abf496a3e37e12b85dd9959f5b70341
commit: b1dcdefc3abf496a3e37e12b85dd9959f5b70341
branch: main
author: Zackery Spytz <zspytz at gmail.com>
committer: iritkatriel <1055913+iritkatriel at users.noreply.github.com>
date: 2022年11月25日T09:21:25Z
summary:
bpo-41260: C impl of datetime.date.strftime() takes different keyword arg (GH-21712)
files:
A Misc/NEWS.d/next/Library/2020-08-02-23-46-22.bpo-41260.Q2BNzY.rst
M Lib/datetime.py
M Lib/test/datetimetester.py

diff --git a/Lib/datetime.py b/Lib/datetime.py
index 01742680a95b..1b0c5cb2d1c6 100644
--- a/Lib/datetime.py
+++ b/Lib/datetime.py
@@ -1032,13 +1032,13 @@ def ctime(self):
 _MONTHNAMES[self._month],
 self._day, self._year)
 
- def strftime(self, fmt):
+ def strftime(self, format):
 """
 Format using strftime().
 
 Example: "%d/%m/%Y, %H:%M:%S"
 """
- return _wrap_strftime(self, fmt, self.timetuple())
+ return _wrap_strftime(self, format, self.timetuple())
 
 def __format__(self, fmt):
 if not isinstance(fmt, str):
diff --git a/Lib/test/datetimetester.py b/Lib/test/datetimetester.py
index bba96698e9e2..121d973b6d5f 100644
--- a/Lib/test/datetimetester.py
+++ b/Lib/test/datetimetester.py
@@ -1489,6 +1489,9 @@ def test_strftime(self):
 #check that this standard extension works
 t.strftime("%f")
 
+ # bpo-41260: The parameter was named "fmt" in the pure python impl.
+ t.strftime(format="%f")
+
 def test_strftime_trailing_percent(self):
 # bpo-35066: Make sure trailing '%' doesn't cause datetime's strftime to
 # complain. Different libcs have different handling of trailing
diff --git a/Misc/NEWS.d/next/Library/2020-08-02-23-46-22.bpo-41260.Q2BNzY.rst b/Misc/NEWS.d/next/Library/2020-08-02-23-46-22.bpo-41260.Q2BNzY.rst
new file mode 100644
index 000000000000..ae2fdd9b84a0
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2020-08-02-23-46-22.bpo-41260.Q2BNzY.rst
@@ -0,0 +1,2 @@
+Rename the *fmt* parameter of the pure Python implementation of
+:meth:`datetime.date.strftime` to *format*.
