[Python-checkins] gh-94637: Release GIL in SSLContext.set_default_verify_paths (GH-94658)

Sat Jul 9 12:11:26 EDT 2022

https://github.com/python/cpython/commit/78307c7dc2352b6633138466debd4c10fae32970
commit: 78307c7dc2352b6633138466debd4c10fae32970
branch: main
author: Christian Heimes <christian at python.org>
committer: tiran <christian at python.org>
date: 2022年07月09日T18:11:15+02:00
summary:
gh-94637: Release GIL in SSLContext.set_default_verify_paths (GH-94658)
files:
A Misc/NEWS.d/next/Library/2022-07-07-15-46-55.gh-issue-94637.IYEiUM.rst
M Modules/_ssl.c

diff --git a/Misc/NEWS.d/next/Library/2022-07-07-15-46-55.gh-issue-94637.IYEiUM.rst b/Misc/NEWS.d/next/Library/2022-07-07-15-46-55.gh-issue-94637.IYEiUM.rst
new file mode 100644
index 0000000000000..20cbbcd5088b7
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-07-07-15-46-55.gh-issue-94637.IYEiUM.rst
@@ -0,0 +1,3 @@
+:meth:`SSLContext.set_default_verify_paths` now releases the GIL around
+``SSL_CTX_set_default_verify_paths`` call. The function call performs I/O
+and CPU intensive work.
diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index 8ff15d18fb637..78c02c1cd82fb 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -4302,7 +4302,11 @@ static PyObject *
 _ssl__SSLContext_set_default_verify_paths_impl(PySSLContext *self)
 /*[clinic end generated code: output=0bee74e6e09deaaa input=35f3408021463d74]*/
 {
- if (!SSL_CTX_set_default_verify_paths(self->ctx)) {
+ int rc;
+ Py_BEGIN_ALLOW_THREADS
+ rc = SSL_CTX_set_default_verify_paths(self->ctx);
+ Py_END_ALLOW_THREADS
+ if (!rc) {
 _setSSLError(get_state_ctx(self), NULL, 0, __FILE__, __LINE__);
 return NULL;
 }
