[Python-checkins] bpo-25460: Surround suggestions by quotes (GH-25473)

Mon Apr 19 18:36:06 EDT 2021

https://github.com/python/cpython/commit/7a041162468b83f6cad667b78ed5c786286aed2b
commit: 7a041162468b83f6cad667b78ed5c786286aed2b
branch: master
author: Pablo Galindo <Pablogsal at gmail.com>
committer: pablogsal <Pablogsal at gmail.com>
date: 2021年04月19日T23:35:53+01:00
summary:
bpo-25460: Surround suggestions by quotes (GH-25473)
files:
M Lib/test/test_exceptions.py
M Python/pythonrun.c

diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index d1e1b196c4278..d93b0f16c91d1 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -1453,12 +1453,12 @@ def EliminationOverAddition():
 bluc = None
 print(bluch)
 
- for func, suggestion in [(Substitution, "blech?"),
- (Elimination, "blch?"),
- (Addition, "bluchin?"),
- (EliminationOverAddition, "blucha?"),
- (SubstitutionOverElimination, "blach?"),
- (SubstitutionOverAddition, "blach?")]:
+ for func, suggestion in [(Substitution, "'blech'?"),
+ (Elimination, "'blch'?"),
+ (Addition, "'bluchin'?"),
+ (EliminationOverAddition, "'blucha'?"),
+ (SubstitutionOverElimination, "'blach'?"),
+ (SubstitutionOverAddition, "'blach'?")]:
 err = None
 try:
 func()
@@ -1475,7 +1475,7 @@ def func():
 except NameError as exc:
 with support.captured_stderr() as err:
 sys.__excepthook__(*sys.exc_info())
- self.assertIn("global_for_suggestions?", err.getvalue())
+ self.assertIn("'global_for_suggestions'?", err.getvalue())
 
 def test_name_error_suggestions_from_builtins(self):
 def func():
@@ -1485,7 +1485,7 @@ def func():
 except NameError as exc:
 with support.captured_stderr() as err:
 sys.__excepthook__(*sys.exc_info())
- self.assertIn("AttributeError?", err.getvalue())
+ self.assertIn("'AttributeError'?", err.getvalue())
 
 def test_name_error_suggestions_do_not_trigger_for_long_names(self):
 def f():
@@ -1628,12 +1628,12 @@ class EliminationOverAddition:
 blucha = None
 bluc = None
 
- for cls, suggestion in [(Substitution, "blech?"),
- (Elimination, "blch?"),
- (Addition, "bluchin?"),
- (EliminationOverAddition, "bluc?"),
- (SubstitutionOverElimination, "blach?"),
- (SubstitutionOverAddition, "blach?")]:
+ for cls, suggestion in [(Substitution, "'blech'?"),
+ (Elimination, "'blch'?"),
+ (Addition, "'bluchin'?"),
+ (EliminationOverAddition, "'bluc'?"),
+ (SubstitutionOverElimination, "'blach'?"),
+ (SubstitutionOverAddition, "'blach'?")]:
 try:
 cls().bluch
 except AttributeError as exc:
diff --git a/Python/pythonrun.c b/Python/pythonrun.c
index 6f84cab702e98..8bd31348b2676 100644
--- a/Python/pythonrun.c
+++ b/Python/pythonrun.c
@@ -956,10 +956,10 @@ print_exception(PyObject *f, PyObject *value)
 PyObject* suggestions = _Py_Offer_Suggestions(value);
 if (suggestions) {
 // Add a trailer ". Did you mean: (...)?"
- err = PyFile_WriteString(". Did you mean: ", f);
+ err = PyFile_WriteString(". Did you mean: '", f);
 if (err == 0) {
 err = PyFile_WriteObject(suggestions, f, Py_PRINT_RAW);
- err += PyFile_WriteString("?", f);
+ err += PyFile_WriteString("'?", f);
 }
 Py_DECREF(suggestions);
 } else if (PyErr_Occurred()) {
