[Python-checkins] bpo-35766 follow-up: Add an error check to new_type_comment() (#11766)

Mon Feb 11 11:10:48 EST 2019

https://github.com/python/cpython/commit/4b250fc1da9c893803cf724a4974450b5e10bd8a
commit: 4b250fc1da9c893803cf724a4974450b5e10bd8a
branch: master
author: Guido van Rossum <guido at python.org>
committer: GitHub <noreply at github.com>
date: 2019年02月11日T08:10:42-08:00
summary:
bpo-35766 follow-up: Add an error check to new_type_comment() (#11766)
If PyUnicode_DecodeUTF8() returns NULL, PyArena_AddPyObject() would crash.
Found by @msullivan for https://github.com/python/typed_ast/pull/93.
files:
M Python/ast.c

diff --git a/Python/ast.c b/Python/ast.c
index 76588c345f27..5cef3fdadc9a 100644
--- a/Python/ast.c
+++ b/Python/ast.c
@@ -702,6 +702,8 @@ static string
 new_type_comment(const char *s, struct compiling *c)
 {
 PyObject *res = PyUnicode_DecodeUTF8(s, strlen(s), NULL);
+ if (res == NULL)
+ return NULL;
 if (PyArena_AddPyObject(c->c_arena, res) < 0) {
 Py_DECREF(res);
 return NULL;
