[Python-checkins] bpo-36389: Cleanup gc.set_threshold() (GH-12844)

Mon Apr 15 11:54:14 EDT 2019

https://github.com/python/cpython/commit/0810fa79885276114d1a94e2ce61da367ebb1ffc
commit: 0810fa79885276114d1a94e2ce61da367ebb1ffc
branch: master
author: Victor Stinner <vstinner at redhat.com>
committer: GitHub <noreply at github.com>
date: 2019年04月15日T17:54:09+02:00
summary:
bpo-36389: Cleanup gc.set_threshold() (GH-12844)
Don't assign generations[2].threshold to generations[2].threshold:
useless operation.
files:
M Modules/gcmodule.c

diff --git a/Modules/gcmodule.c b/Modules/gcmodule.c
index fad1356d6b44..a75d5fed95f1 100644
--- a/Modules/gcmodule.c
+++ b/Modules/gcmodule.c
@@ -1374,7 +1374,7 @@ gc_set_thresh(PyObject *self, PyObject *args)
 &_PyRuntime.gc.generations[1].threshold,
 &_PyRuntime.gc.generations[2].threshold))
 return NULL;
- for (i = 2; i < NUM_GENERATIONS; i++) {
+ for (i = 3; i < NUM_GENERATIONS; i++) {
 /* generations higher than 2 get the same threshold */
 _PyRuntime.gc.generations[i].threshold = _PyRuntime.gc.generations[2].threshold;
 }
@@ -1524,7 +1524,7 @@ gc_get_objects_impl(PyObject *module, Py_ssize_t generation)
 }
 
 /* If generation is passed, we extract only that generation */
- if (generation != -1) { 
+ if (generation != -1) {
 if (generation >= NUM_GENERATIONS) {
 PyErr_Format(PyExc_ValueError,
 "generation parameter must be less than the number of "
