[Python-checkins] bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)

Wed Sep 12 17:05:23 EDT 2018

https://github.com/python/cpython/commit/6f82bffd2df63a4072b3f0483cdbe93ddedb87e9
commit: 6f82bffd2df63a4072b3f0483cdbe93ddedb87e9
branch: master
author: Alexey Izbyshev <izbyshev at ispras.ru>
committer: Berker Peksag <berker.peksag at gmail.com>
date: 2018年09月13日T00:05:20+03:00
summary:
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
Reported by Svace static analyzer.
files:
M Modules/_json.c

diff --git a/Modules/_json.c b/Modules/_json.c
index 5a9464e34fb7..ac6e017a4eaf 100644
--- a/Modules/_json.c
+++ b/Modules/_json.c
@@ -1374,7 +1374,7 @@ _encoded_const(PyObject *obj)
 if (s_null == NULL) {
 s_null = PyUnicode_InternFromString("null");
 }
- Py_INCREF(s_null);
+ Py_XINCREF(s_null);
 return s_null;
 }
 else if (obj == Py_True) {
@@ -1382,7 +1382,7 @@ _encoded_const(PyObject *obj)
 if (s_true == NULL) {
 s_true = PyUnicode_InternFromString("true");
 }
- Py_INCREF(s_true);
+ Py_XINCREF(s_true);
 return s_true;
 }
 else if (obj == Py_False) {
@@ -1390,7 +1390,7 @@ _encoded_const(PyObject *obj)
 if (s_false == NULL) {
 s_false = PyUnicode_InternFromString("false");
 }
- Py_INCREF(s_false);
+ Py_XINCREF(s_false);
 return s_false;
 }
 else {
