[Python-checkins] Fix a possible "double decref" in termios.tcgetattr(). (GH-10194)

Mon Oct 29 00:55:28 EDT 2018

https://github.com/python/cpython/commit/53835e92d315340444e3dd083b3f69a590b00e07
commit: 53835e92d315340444e3dd083b3f69a590b00e07
branch: master
author: Zackery Spytz <zspytz at gmail.com>
committer: Serhiy Storchaka <storchaka at gmail.com>
date: 2018年10月29日T06:55:20+02:00
summary:
Fix a possible "double decref" in termios.tcgetattr(). (GH-10194)
files:
M Modules/termios.c

diff --git a/Modules/termios.c b/Modules/termios.c
index b4aa77f89764..7601b68afda3 100644
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -119,11 +119,11 @@ termios_tcgetattr(PyObject *self, PyObject *args)
 PyList_SetItem(v, 3, PyLong_FromLong((long)mode.c_lflag));
 PyList_SetItem(v, 4, PyLong_FromLong((long)ispeed));
 PyList_SetItem(v, 5, PyLong_FromLong((long)ospeed));
- PyList_SetItem(v, 6, cc);
- if (PyErr_Occurred()){
+ if (PyErr_Occurred()) {
 Py_DECREF(v);
 goto err;
 }
+ PyList_SetItem(v, 6, cc);
 return v;
 err:
 Py_DECREF(cc);
