[Python-checkins] bpo-34166: Fix warnings in Tools/msgfmt.py. (GH-8367)

Sat Jul 21 03:24:44 EDT 2018

https://github.com/python/cpython/commit/916bcc6fde2db95199454b22f608648467fbbc54
commit: 916bcc6fde2db95199454b22f608648467fbbc54
branch: 3.6
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018年07月21日T00:24:41-07:00
summary:
bpo-34166: Fix warnings in Tools/msgfmt.py. (GH-8367)
(cherry picked from commit a692efe4733f98831cb51a9683877b152f754d14)
Co-authored-by: Xtreak <tirkarthi at users.noreply.github.com>
files:
M Tools/i18n/msgfmt.py

diff --git a/Tools/i18n/msgfmt.py b/Tools/i18n/msgfmt.py
index b0751a1ffc1d..63d52d1f46e5 100755
--- a/Tools/i18n/msgfmt.py
+++ b/Tools/i18n/msgfmt.py
@@ -89,7 +89,7 @@ def generate():
 7*4, # start of key index
 7*4+len(keys)*8, # start of value index
 0, 0) # size and offset of hash table
- output += array.array("i", offsets).tostring()
+ output += array.array("i", offsets).tobytes()
 output += ids
 output += strs
 return output
@@ -109,7 +109,8 @@ def make(filename, outfile):
 outfile = os.path.splitext(infile)[0] + '.mo'
 
 try:
- lines = open(infile, 'rb').readlines()
+ with open(infile, 'rb') as f:
+ lines = f.readlines()
 except IOError as msg:
 print(msg, file=sys.stderr)
 sys.exit(1)
@@ -199,7 +200,8 @@ def make(filename, outfile):
 output = generate()
 
 try:
- open(outfile,"wb").write(output)
+ with open(outfile,"wb") as f:
+ f.write(output)
 except IOError as msg:
 print(msg, file=sys.stderr)
 
