[Python-checkins] Exhaustively test dataclass hashing when no hash= value is provided. This is in anticipation of changing how non-default hashing is handled. (GH-5834) (GH-5889)

Sun Feb 25 15:38:20 EST 2018

On 2/25/2018 1:49 PM, Eric V. Smith wrote:
> On 2/25/2018 1:36 PM, Terry Reedy wrote:
>> On 2/25/2018 11:56 AM, Eric V. Smith wrote:
>>>>> +        # specify any value in the deecorator).
>>>> I fixed this through the web interface.

Let's say I tried to. It seems that I misunderstood button labels and 
only changed my fork.
>>  The CI now knows that a 
>> comment change does not need testing.

Wrong. There is no CI for my fork ;-).
>> I could not request a review from ericvsmith though.

I made new PR against python/cpython
https://github.com/python/cpython/pull/5899
and it auto requested review from you.
I will leave this for you to merge or not.
 > Thanks. Do you know if this gets backported to 3.7?
It will if you add backport-37 label.
I have not seen a backport for the original.
-Terry