[Python-checkins] bpo-11566: Extension build errors on Windows for _hypot (GH-11283)

Fri Dec 21 20:57:03 EST 2018

https://github.com/python/cpython/commit/c046d6b6187e4de98a29e67ccbfd9b1b8790ee2f
commit: c046d6b6187e4de98a29e67ccbfd9b1b8790ee2f
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: GitHub <noreply at github.com>
date: 2018年12月21日T17:56:58-08:00
summary:
bpo-11566: Extension build errors on Windows for _hypot (GH-11283)
This addresses C extension build errors related to an undefined _hypot
symbol when building with the Microsoft Visual C++ Compiler for Python
2.7 [1] or MinGWPy [2]. It also addresses errors when building a C++
extension with MinGWPy and C++11 from cmath, 'error "::hypot' has not
been declared'
[1] https://www.microsoft.com/en-us/download/details.aspx?id=44266
[2] https://mingwpy.github.io/
(cherry picked from commit 87667c54c6650751c5d7bf7b9e465c8c4af45f71)
Co-authored-by: Matt McCormick <matt at mmmccormick.com>
files:
M PC/pyconfig.h

diff --git a/PC/pyconfig.h b/PC/pyconfig.h
index d2a3f5dd39bb..bb9171fbcb7d 100644
--- a/PC/pyconfig.h
+++ b/PC/pyconfig.h
@@ -192,11 +192,6 @@ typedef int pid_t;
 #define Py_IS_FINITE(X) _finite(X)
 #define copysign _copysign
 
-/* VS 2010 and above already defines hypot as _hypot */
-#if _MSC_VER < 1600
-#define hypot _hypot
-#endif
-
 /* VS 2015 defines these names with a leading underscore */
 #if _MSC_VER >= 1900
 #define timezone _timezone
@@ -231,7 +226,6 @@ typedef int pid_t;
 #endif
 
 #define COMPILER "[gcc]"
-#define hypot _hypot
 #define PY_LONG_LONG long long
 #define PY_LLONG_MIN LLONG_MIN
 #define PY_LLONG_MAX LLONG_MAX
