[Python-checkins] [3.6] bpo-30978: str.format_map() now passes key lookup exceptions through. (GH-2790) (#2992)

Thu Aug 3 05:14:11 EDT 2017

https://github.com/python/cpython/commit/f08b2be4416163e3d18b8d09891e7cda0d8a21d4
commit: f08b2be4416163e3d18b8d09891e7cda0d8a21d4
branch: 3.6
author: Serhiy Storchaka <storchaka at gmail.com>
committer: GitHub <noreply at github.com>
date: 2017年08月03日T12:14:07+03:00
summary:
[3.6] bpo-30978: str.format_map() now passes key lookup exceptions through. (GH-2790) (#2992)
Previously any exception was replaced with a KeyError exception.
(cherry picked from commit 5075416)
files:
A Misc/NEWS.d/next/Core and Builtins/2017-07-21-07-39-05.bpo-30978.f0jODc.rst
M Lib/test/test_re.py
M Lib/test/test_unicode.py
M Objects/stringlib/unicode_format.h

diff --git a/Lib/test/test_re.py b/Lib/test/test_re.py
index a6cbbd0b67a..e23e5a9a6ca 100644
--- a/Lib/test/test_re.py
+++ b/Lib/test/test_re.py
@@ -471,7 +471,7 @@ def test_match_getitem(self):
 m[(0,)]
 with self.assertRaisesRegex(IndexError, 'no such group'):
 m[(0, 1)]
- with self.assertRaisesRegex(KeyError, 'a2'):
+ with self.assertRaisesRegex(IndexError, 'no such group'):
 'a1={a2}'.format_map(m)
 
 m = pat.match('ac')
diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py
index 2844bc5540c..56ab0ad7329 100644
--- a/Lib/test/test_unicode.py
+++ b/Lib/test/test_unicode.py
@@ -1279,6 +1279,13 @@ def __format__(self, spec):
 self.assertRaises(ValueError, '{}'.format_map, 'a')
 self.assertRaises(ValueError, '{a} {}'.format_map, {"a" : 2, "b" : 1})
 
+ class BadMapping:
+ def __getitem__(self, key):
+ return 1/0
+ self.assertRaises(KeyError, '{a}'.format_map, {})
+ self.assertRaises(TypeError, '{a}'.format_map, [])
+ self.assertRaises(ZeroDivisionError, '{a}'.format_map, BadMapping())
+
 def test_format_huge_precision(self):
 format_string = ".{}f".format(sys.maxsize + 1)
 with self.assertRaises(ValueError):
diff --git a/Misc/NEWS.d/next/Core and Builtins/2017-07-21-07-39-05.bpo-30978.f0jODc.rst b/Misc/NEWS.d/next/Core and Builtins/2017-07-21-07-39-05.bpo-30978.f0jODc.rst
new file mode 100644
index 00000000000..bb67a9fb244
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2017-07-21-07-39-05.bpo-30978.f0jODc.rst	
@@ -0,0 +1,2 @@
+str.format_map() now passes key lookup exceptions through.
+Previously any exception was replaced with a KeyError exception.
diff --git a/Objects/stringlib/unicode_format.h b/Objects/stringlib/unicode_format.h
index 14fa28ea54a..7314af02a4a 100644
--- a/Objects/stringlib/unicode_format.h
+++ b/Objects/stringlib/unicode_format.h
@@ -412,18 +412,22 @@ get_field_object(SubString *input, PyObject *args, PyObject *kwargs,
 if (index == -1) {
 /* look up in kwargs */
 PyObject *key = SubString_new_object(&first);
- if (key == NULL)
+ if (key == NULL) {
 goto error;
-
- /* Use PyObject_GetItem instead of PyDict_GetItem because this
- code is no longer just used with kwargs. It might be passed
- a non-dict when called through format_map. */
- if ((kwargs == NULL) || (obj = PyObject_GetItem(kwargs, key)) == NULL) {
+ }
+ if (kwargs == NULL) {
 PyErr_SetObject(PyExc_KeyError, key);
 Py_DECREF(key);
 goto error;
 }
+ /* Use PyObject_GetItem instead of PyDict_GetItem because this
+ code is no longer just used with kwargs. It might be passed
+ a non-dict when called through format_map. */
+ obj = PyObject_GetItem(kwargs, key);
 Py_DECREF(key);
+ if (obj == NULL) {
+ goto error;
+ }
 }
 else {
 /* If args is NULL, we have a format string with a positional field
