[Python-checkins] cpython (3.5): Issue #27245: IDLE: Cleanly delete custom themes and key bindings.

Tue Jun 14 00:54:03 EDT 2016

https://hg.python.org/cpython/rev/438359d00a83
changeset: 102001:438359d00a83
branch: 3.5
parent: 101998:96d297e9a8a8
user: Terry Jan Reedy <tjreedy at udel.edu>
date: Tue Jun 14 00:53:25 2016 -0400
summary:
 Issue #27245: IDLE: Cleanly delete custom themes and key bindings.
Previously, when IDLE was started from a console or by import, a cascade
of warnings was emitted. Patch by Serhiy Storchaka.
files:
 Lib/idlelib/configDialog.py | 8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Lib/idlelib/configDialog.py b/Lib/idlelib/configDialog.py
--- a/Lib/idlelib/configDialog.py
+++ b/Lib/idlelib/configDialog.py
@@ -751,6 +751,7 @@
 if not tkMessageBox.askyesno(
 'Delete Key Set', delmsg % keySetName, parent=self):
 return
+ self.DeactivateCurrentConfig()
 #remove key set from config
 idleConf.userCfg['keys'].remove_section(keySetName)
 if keySetName in self.changedItems['keys']:
@@ -769,7 +770,8 @@
 self.keysAreBuiltin.set(idleConf.defaultCfg['main'].Get('Keys', 'default'))
 self.builtinKeys.set(idleConf.defaultCfg['main'].Get('Keys', 'name'))
 #user can't back out of these changes, they must be applied now
- self.Apply()
+ self.SaveAllChangedConfigs()
+ self.ActivateConfigChanges()
 self.SetKeysType()
 
 def DeleteCustomTheme(self):
@@ -778,6 +780,7 @@
 if not tkMessageBox.askyesno(
 'Delete Theme', delmsg % themeName, parent=self):
 return
+ self.DeactivateCurrentConfig()
 #remove theme from config
 idleConf.userCfg['highlight'].remove_section(themeName)
 if themeName in self.changedItems['highlight']:
@@ -796,7 +799,8 @@
 self.themeIsBuiltin.set(idleConf.defaultCfg['main'].Get('Theme', 'default'))
 self.builtinTheme.set(idleConf.defaultCfg['main'].Get('Theme', 'name'))
 #user can't back out of these changes, they must be applied now
- self.Apply()
+ self.SaveAllChangedConfigs()
+ self.ActivateConfigChanges()
 self.SetThemeType()
 
 def GetColour(self):
-- 
Repository URL: https://hg.python.org/cpython
