[Python-checkins] cpython: Issue #28919: Simplify _copy_func_details() in unittest.mock

Wed Dec 14 21:20:51 EST 2016

https://hg.python.org/cpython/rev/bbdfde7958a8
changeset: 105628:bbdfde7958a8
user: Berker Peksag <berker.peksag at gmail.com>
date: Thu Dec 15 05:21:44 2016 +0300
summary:
 Issue #28919: Simplify _copy_func_details() in unittest.mock
Patch by Jiajun Huang.
files:
 Lib/unittest/mock.py | 26 ++++++++------------------
 1 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/Lib/unittest/mock.py b/Lib/unittest/mock.py
--- a/Lib/unittest/mock.py
+++ b/Lib/unittest/mock.py
@@ -104,26 +104,16 @@
 
 
 def _copy_func_details(func, funcopy):
- funcopy.__name__ = func.__name__
- funcopy.__doc__ = func.__doc__
- try:
- funcopy.__text_signature__ = func.__text_signature__
- except AttributeError:
- pass
 # we explicitly don't copy func.__dict__ into this copy as it would
 # expose original attributes that should be mocked
- try:
- funcopy.__module__ = func.__module__
- except AttributeError:
- pass
- try:
- funcopy.__defaults__ = func.__defaults__
- except AttributeError:
- pass
- try:
- funcopy.__kwdefaults__ = func.__kwdefaults__
- except AttributeError:
- pass
+ for attribute in (
+ '__name__', '__doc__', '__text_signature__',
+ '__module__', '__defaults__', '__kwdefaults__',
+ ):
+ try:
+ setattr(funcopy, attribute, getattr(func, attribute))
+ except AttributeError:
+ pass
 
 
 def _callable(obj):
-- 
Repository URL: https://hg.python.org/cpython
