[Python-checkins] cpython (3.4): Issue #21827: Fixed textwrap.dedent() for the case when largest common

Wed Oct 28 15:45:50 EDT 2015

https://hg.python.org/cpython/rev/faeeb8dbe432
changeset: 98876:faeeb8dbe432
branch: 3.4
parent: 98873:8b1418e5dcc8
user: Serhiy Storchaka <storchaka at gmail.com>
date: Wed Oct 28 21:39:36 2015 +0200
summary:
 Issue #21827: Fixed textwrap.dedent() for the case when largest common
whitespace is a substring of smallest leading whitespace.
Based on patch by Robert Li.
files:
 Lib/test/test_textwrap.py | 5 +++++
 Lib/textwrap.py | 12 ++++++++----
 Misc/ACKS | 1 +
 Misc/NEWS | 4 ++++
 4 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/Lib/test/test_textwrap.py b/Lib/test/test_textwrap.py
--- a/Lib/test/test_textwrap.py
+++ b/Lib/test/test_textwrap.py
@@ -732,6 +732,11 @@
 expect = "hello there\n how are you?"
 self.assertEqual(expect, dedent(text))
 
+ # test margin is smaller than smallest indent
+ text = " \thello there\n \thow are you?\n \tI'm fine, thanks"
+ expect = " \thello there\n \thow are you?\n\tI'm fine, thanks"
+ self.assertEqual(expect, dedent(text))
+
 
 # Test textwrap.indent
 class IndentTestCase(unittest.TestCase):
diff --git a/Lib/textwrap.py b/Lib/textwrap.py
--- a/Lib/textwrap.py
+++ b/Lib/textwrap.py
@@ -429,11 +429,15 @@
 elif margin.startswith(indent):
 margin = indent
 
- # Current line and previous winner have no common whitespace:
- # there is no margin.
+ # Find the largest common whitespace between current line and previous
+ # winner.
 else:
- margin = ""
- break
+ for i, (x, y) in enumerate(zip(margin, indent)):
+ if x != y:
+ margin = margin[:i]
+ break
+ else:
+ margin = margin[:len(indent)]
 
 # sanity check (testing/debugging only)
 if 0 and margin:
diff --git a/Misc/ACKS b/Misc/ACKS
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -823,6 +823,7 @@
 Ivan Levkivskyi
 William Lewis
 Akira Li
+Robert Li
 Xuanji Li
 Robert van Liere
 Ross Light
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -96,6 +96,10 @@
 Library
 -------
 
+- Issue #21827: Fixed textwrap.dedent() for the case when largest common
+ whitespace is a substring of smallest leading whitespace.
+ Based on patch by Robert Li.
+
 - Issue #25471: Sockets returned from accept() shouldn't appear to be
 nonblocking.
 
-- 
Repository URL: https://hg.python.org/cpython
