[Python-checkins] cpython: Issue #22117: Fix test_gdb for the new time.sleep()

Fri Mar 27 15:44:53 CET 2015

https://hg.python.org/cpython/rev/b0b4c4d365b1
changeset: 95220:b0b4c4d365b1
user: Victor Stinner <victor.stinner at gmail.com>
date: Fri Mar 27 15:42:37 2015 +0100
summary:
 Issue #22117: Fix test_gdb for the new time.sleep()
Use time.gmtime() instead of time.sleep(), because time.sleep() is no more
declared with METH_VARARGS but with METH_O. time.gmtime() is still declared
with METH_VARARGS and so it is called with PyCFunction_Call() which is the
target of the test_gdb unit test.
files:
 Lib/test/test_gdb.py | 14 ++++++++------
 1 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py
--- a/Lib/test/test_gdb.py
+++ b/Lib/test/test_gdb.py
@@ -802,25 +802,27 @@
 "Python was compiled without thread support")
 def test_pycfunction(self):
 'Verify that "py-bt" displays invocations of PyCFunction instances'
- cmd = ('from time import sleep\n'
+ # Tested function must not be defined with METH_NOARGS or METH_O,
+ # otherwise call_function() doesn't call PyCFunction_Call()
+ cmd = ('from time import gmtime\n'
 'def foo():\n'
- ' sleep(1)\n'
+ ' gmtime(1)\n'
 'def bar():\n'
 ' foo()\n'
 'bar()\n')
 # Verify with "py-bt":
 gdb_output = self.get_stack_trace(cmd,
- breakpoint='time_sleep',
+ breakpoint='time_gmtime',
 cmds_after_breakpoint=['bt', 'py-bt'],
 )
- self.assertIn('<built-in method sleep', gdb_output)
+ self.assertIn('<built-in method gmtime', gdb_output)
 
 # Verify with "py-bt-full":
 gdb_output = self.get_stack_trace(cmd,
- breakpoint='time_sleep',
+ breakpoint='time_gmtime',
 cmds_after_breakpoint=['py-bt-full'],
 )
- self.assertIn('#0 <built-in method sleep', gdb_output)
+ self.assertIn('#0 <built-in method gmtime', gdb_output)
 
 
 class PyPrintTests(DebuggerTests):
-- 
Repository URL: https://hg.python.org/cpython
