[Python-checkins] cpython: Remove the obsolete MAXFD constant and Popen._close_fds() method.

Sun Jun 1 09:33:47 CEST 2014

http://hg.python.org/cpython/rev/f98b0a5e5ef5
changeset: 90939:f98b0a5e5ef5
user: Gregory P. Smith <greg at krypto.org>
date: Sun Jun 01 00:33:35 2014 -0700
summary:
 Remove the obsolete MAXFD constant and Popen._close_fds() method.
They should have been removed years ago when removing the old pure
Python implementation from the file.
files:
 Lib/subprocess.py | 14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/Lib/subprocess.py b/Lib/subprocess.py
--- a/Lib/subprocess.py
+++ b/Lib/subprocess.py
@@ -469,10 +469,6 @@
 __del__ = Close
 __str__ = __repr__
 
-try:
- MAXFD = os.sysconf("SC_OPEN_MAX")
-except:
- MAXFD = 256
 
 # This lists holds Popen instances for which the underlying process had not
 # exited at the time its __del__ method got called: those processes are wait()ed
@@ -1335,16 +1331,6 @@
 errread, errwrite)
 
 
- def _close_fds(self, fds_to_keep):
- start_fd = 3
- for fd in sorted(fds_to_keep):
- if fd >= start_fd:
- os.closerange(start_fd, fd)
- start_fd = fd + 1
- if start_fd <= MAXFD:
- os.closerange(start_fd, MAXFD)
-
-
 def _execute_child(self, args, executable, preexec_fn, close_fds,
 pass_fds, cwd, env,
 startupinfo, creationflags, shell,
-- 
Repository URL: http://hg.python.org/cpython
