[Python-checkins] cpython: asyncio: Cleanup logging in BaseEventLoop._run_once()

Wed Jan 22 12:27:00 CET 2014

http://hg.python.org/cpython/rev/a62072cf50a2
changeset: 88635:a62072cf50a2
user: Victor Stinner <victor.stinner at gmail.com>
date: Wed Jan 22 12:26:01 2014 +0100
summary:
 asyncio: Cleanup logging in BaseEventLoop._run_once()
logger.log() is now responsible to format the timeout. It might be faster if
the log is disabled for DEBUG level, but it's also more readable and fix
an issue with Python 2.6 in the Trollius project.
files:
 Lib/asyncio/base_events.py | 7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Lib/asyncio/base_events.py b/Lib/asyncio/base_events.py
--- a/Lib/asyncio/base_events.py
+++ b/Lib/asyncio/base_events.py
@@ -614,12 +614,15 @@
 t0 = self.time()
 event_list = self._selector.select(timeout)
 t1 = self.time()
- argstr = '' if timeout is None else ' {:.3f}'.format(timeout)
 if t1-t0 >= 1:
 level = logging.INFO
 else:
 level = logging.DEBUG
- logger.log(level, 'poll%s took %.3f seconds', argstr, t1-t0)
+ if timeout is not None:
+ logger.log(level, 'poll %.3f took %.3f seconds',
+ timeout, t1-t0)
+ else:
+ logger.log(level, 'poll took %.3f seconds', t1-t0)
 else:
 event_list = self._selector.select(timeout)
 self._process_events(event_list)
-- 
Repository URL: http://hg.python.org/cpython
