[Python-checkins] cpython (2.7): Issue #19112: avoid using function defined in method.

Sun Sep 29 18:34:35 CEST 2013

http://hg.python.org/cpython/rev/a3dd2ccdccf6
changeset: 85850:a3dd2ccdccf6
branch: 2.7
parent: 85848:792006307d6d
user: Richard Oudkerk <shibturn at gmail.com>
date: Sun Sep 29 17:10:40 2013 +0100
summary:
 Issue #19112: avoid using function defined in method.
files:
 Lib/test/test_multiprocessing.py | 17 +++++++++--------
 1 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/Lib/test/test_multiprocessing.py b/Lib/test/test_multiprocessing.py
--- a/Lib/test/test_multiprocessing.py
+++ b/Lib/test/test_multiprocessing.py
@@ -2287,12 +2287,19 @@
 # Verifies os.close(sys.stdin.fileno) vs. sys.stdin.close() behavior
 #
 
-def _ThisSubProcess(q):
+def _this_sub_process(q):
 try:
 item = q.get(block=False)
 except Queue.Empty:
 pass
 
+def _test_process(q):
+ queue = multiprocessing.Queue()
+ subProc = multiprocessing.Process(target=_this_sub_process, args=(queue,))
+ subProc.daemon = True
+ subProc.start()
+ subProc.join()
+
 def _afunc(x):
 return x*x
 
@@ -2324,14 +2331,8 @@
 class TestStdinBadfiledescriptor(unittest.TestCase):
 
 def test_queue_in_process(self):
- def _TestProcess(q):
- queue = multiprocessing.Queue()
- subProc = multiprocessing.Process(target=_ThisSubProcess, args=(queue,))
- subProc.daemon = True
- subProc.start()
- subProc.join()
 queue = multiprocessing.Queue()
- proc = multiprocessing.Process(target=_TestProcess, args=(queue,))
+ proc = multiprocessing.Process(target=_test_process, args=(queue,))
 proc.start()
 proc.join()
 
-- 
Repository URL: http://hg.python.org/cpython
