[Python-checkins] cpython (3.2): Issue #16564: Fixed a performance regression relative to Python 3.1 in the

Sat Mar 16 21:56:37 CET 2013

http://hg.python.org/cpython/rev/14fe7a98b89c
changeset: 82703:14fe7a98b89c
branch: 3.2
parent: 82697:5d26de06fc38
user: Serhiy Storchaka <storchaka at gmail.com>
date: Sat Mar 16 22:52:09 2013 +0200
summary:
 Issue #16564: Fixed a performance regression relative to Python 3.1 in the
caching of compiled regular expressions.
files:
 Lib/re.py | 34 +++++++++++++++++++++++++---------
 Misc/NEWS | 3 +++
 2 files changed, 28 insertions(+), 9 deletions(-)

diff --git a/Lib/re.py b/Lib/re.py
--- a/Lib/re.py
+++ b/Lib/re.py
@@ -215,8 +215,8 @@
 
 def purge():
 "Clear the regular expression caches"
- _compile_typed.cache_clear()
- _compile_repl.cache_clear()
+ _cache.clear()
+ _cache_repl.clear()
 
 def template(pattern, flags=0):
 "Compile a template pattern, returning a pattern object"
@@ -257,14 +257,19 @@
 # --------------------------------------------------------------------
 # internals
 
+_cache = {}
+_cache_repl = {}
+
 _pattern_type = type(sre_compile.compile("", 0))
 
+_MAXCACHE = 512
+
 def _compile(pattern, flags):
- return _compile_typed(type(pattern), pattern, flags)
-
- at functools.lru_cache(maxsize=500)
-def _compile_typed(text_bytes_type, pattern, flags):
 # internal: compile pattern
+ try:
+ return _cache[type(pattern), pattern, flags]
+ except KeyError:
+ pass
 if isinstance(pattern, _pattern_type):
 if flags:
 raise ValueError(
@@ -272,12 +277,23 @@
 return pattern
 if not sre_compile.isstring(pattern):
 raise TypeError("first argument must be string or compiled pattern")
- return sre_compile.compile(pattern, flags)
+ p = sre_compile.compile(pattern, flags)
+ if len(_cache) >= _MAXCACHE:
+ _cache.clear()
+ _cache[type(pattern), pattern, flags] = p
+ return p
 
- at functools.lru_cache(maxsize=500)
 def _compile_repl(repl, pattern):
 # internal: compile replacement pattern
- return sre_parse.parse_template(repl, pattern)
+ try:
+ return _cache_repl[repl, pattern]
+ except KeyError:
+ pass
+ p = sre_parse.parse_template(repl, pattern)
+ if len(_cache_repl) >= _MAXCACHE:
+ _cache_repl.clear()
+ _cache_repl[repl, pattern] = p
+ return p
 
 def _expand(pattern, match, template):
 # internal: match.expand implementation hook
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -233,6 +233,9 @@
 Library
 -------
 
+- Issue #16564: Fixed a performance regression relative to Python 3.1 in the
+ caching of compiled regular expressions.
+
 - Issue #17431: Fix missing import of BytesFeedParser in email.parser.
 
 - Issue #1285086: Get rid of the refcounting hack and speed up
-- 
Repository URL: http://hg.python.org/cpython
