[Python-checkins] cpython (2.7): Issue #14720: Enhance sqlite3 microsecond conversion, document its behavior

Tue Feb 26 20:47:31 CET 2013

http://hg.python.org/cpython/rev/eb45fd74db34
changeset: 82403:eb45fd74db34
branch: 2.7
parent: 82395:92003d9aae0e
user: Petri Lehtinen <petri at digip.org>
date: Tue Feb 26 21:32:02 2013 +0200
summary:
 Issue #14720: Enhance sqlite3 microsecond conversion, document its behavior
files:
 Doc/library/sqlite3.rst | 4 ++++
 Lib/sqlite3/dbapi2.py | 4 ++--
 Lib/sqlite3/test/regression.py | 13 +++++++++++--
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/Doc/library/sqlite3.rst b/Doc/library/sqlite3.rst
--- a/Doc/library/sqlite3.rst
+++ b/Doc/library/sqlite3.rst
@@ -832,6 +832,10 @@
 
 .. literalinclude:: ../includes/sqlite3/pysqlite_datetime.py
 
+If a timestamp stored in SQLite has a fractional part longer than 6
+numbers, its value will be truncated to microsecond precision by the
+timestamp converter.
+
 
 .. _sqlite3-controlling-transactions:
 
diff --git a/Lib/sqlite3/dbapi2.py b/Lib/sqlite3/dbapi2.py
--- a/Lib/sqlite3/dbapi2.py
+++ b/Lib/sqlite3/dbapi2.py
@@ -1,4 +1,4 @@
-#-*- coding: ISO-8859-1 -*-
+# -*- coding: iso-8859-1 -*-
 # pysqlite2/dbapi2.py: the DB-API 2.0 interface
 #
 # Copyright (C) 2004-2005 Gerhard Häring <gh at ghaering.de>
@@ -68,7 +68,7 @@
 timepart_full = timepart.split(".")
 hours, minutes, seconds = map(int, timepart_full[0].split(":"))
 if len(timepart_full) == 2:
- microseconds = int('{:0<6}'.format(timepart_full[1].decode()))
+ microseconds = int('{:0<6.6}'.format(timepart_full[1].decode()))
 else:
 microseconds = 0
 
diff --git a/Lib/sqlite3/test/regression.py b/Lib/sqlite3/test/regression.py
--- a/Lib/sqlite3/test/regression.py
+++ b/Lib/sqlite3/test/regression.py
@@ -296,11 +296,20 @@
 con = sqlite.connect(":memory:", detect_types=sqlite.PARSE_DECLTYPES)
 cur = con.cursor()
 cur.execute("CREATE TABLE t (x TIMESTAMP)")
+
+ # Microseconds should be 456000
 cur.execute("INSERT INTO t (x) VALUES ('2012-04-04 15:06:00.456')")
+
+ # Microseconds should be truncated to 123456
+ cur.execute("INSERT INTO t (x) VALUES ('2012-04-04 15:06:00.123456789')")
+
 cur.execute("SELECT * FROM t")
- date = cur.fetchall()[0][0]
+ values = [x[0] for x in cur.fetchall()]
 
- self.assertEqual(date, datetime.datetime(2012, 4, 4, 15, 6, 0, 456000))
+ self.assertEqual(values, [
+ datetime.datetime(2012, 4, 4, 15, 6, 0, 456000),
+ datetime.datetime(2012, 4, 4, 15, 6, 0, 123456),
+ ])
 
 
 def suite():
-- 
Repository URL: http://hg.python.org/cpython
