[Python-checkins] cpython (3.2): Issue #16402: In range slicing, fix shadowing of exceptions from index

Sun Nov 4 12:48:12 CET 2012

http://hg.python.org/cpython/rev/94d15358ad6e
changeset: 80236:94d15358ad6e
branch: 3.2
parent: 80233:1805fc284201
user: Mark Dickinson <mdickinson at enthought.com>
date: Sun Nov 04 11:46:17 2012 +0000
summary:
 Issue #16402: In range slicing, fix shadowing of exceptions from __index__ method.
files:
 Lib/test/test_range.py | 9 +++++++++
 Misc/NEWS | 3 +++
 Objects/rangeobject.c | 10 +++++-----
 3 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/Lib/test/test_range.py b/Lib/test/test_range.py
--- a/Lib/test/test_range.py
+++ b/Lib/test/test_range.py
@@ -312,6 +312,15 @@
 
 self.assertRaises(TypeError, range, IN())
 
+ # Test use of user-defined classes in slice indices.
+ self.assertEqual(list(range(10)[:I(5)]), list(range(5)))
+
+ with self.assertRaises(RuntimeError):
+ range(0, 10)[:IX()]
+
+ with self.assertRaises(TypeError):
+ range(0, 10)[:IN()]
+
 def test_count(self):
 self.assertEqual(range(3).count(-1), 0)
 self.assertEqual(range(3).count(0), 1)
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@
 Core and Builtins
 -----------------
 
+- Issue #16402: When slicing a range, fix shadowing of exceptions from
+ __index__.
+
 - Issue #16336: fix input checking in the surrogatepass error handler.
 Patch by Serhiy Storchaka.
 
diff --git a/Objects/rangeobject.c b/Objects/rangeobject.c
--- a/Objects/rangeobject.c
+++ b/Objects/rangeobject.c
@@ -330,11 +330,11 @@
 if (PyIndex_Check(obj)) {
 result = PyNumber_Index(obj);
 }
- }
- if (result == NULL) {
- PyErr_SetString(PyExc_TypeError,
- "slice indices must be integers or "
- "None or have an __index__ method");
+ else {
+ PyErr_SetString(PyExc_TypeError,
+ "slice indices must be integers or "
+ "None or have an __index__ method");
+ }
 }
 return result;
 }
-- 
Repository URL: http://hg.python.org/cpython


[Python-checkins] cpython (3.2): Issue #16402: In range slicing, fix shadowing of exceptions from __index__

[Python-checkins] cpython (3.2): Issue #16402: In range slicing, fix shadowing of exceptions from index