[Python-checkins] cpython (2.7): Issue #6807: Run msisupport.mak earlier.

Tue Feb 21 18:12:08 CET 2012

http://hg.python.org/cpython/rev/e78acdb54841
changeset: 75140:e78acdb54841
branch: 2.7
parent: 75135:40b684215b4f
user: Martin v. Löwis <martin at v.loewis.de>
date: Tue Feb 21 18:12:02 2012 +0100
summary:
 Issue #6807: Run msisupport.mak earlier.
files:
 Misc/NEWS | 2 ++
 Tools/msi/msi.py | 4 ++--
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -517,6 +517,8 @@
 Build
 -----
 
+- Issue #6807: Run msisupport.mak earlier.
+
 - Issue #10580: Minor grammar change in Windows installer.
 
 - Issue #12627: Implement PEP 394 for Python 2.7 ("python2").
diff --git a/Tools/msi/msi.py b/Tools/msi/msi.py
--- a/Tools/msi/msi.py
+++ b/Tools/msi/msi.py
@@ -177,6 +177,8 @@
 have_mingw = build_mingw_lib(lib_file, def_file, dll_file, mingw_lib)
 
 # Determine the target architecture
+if os.system("nmake /nologo /c /f msisupport.mak") != 0:
+ raise RuntimeError("'nmake /f msisupport.mak' failed")
 dll_path = os.path.join(srcdir, PCBUILD, dll_file)
 msilib.set_arch_from_file(dll_path)
 if msilib.pe_type(dll_path) != msilib.pe_type("msisupport.dll"):
@@ -374,8 +376,6 @@
 # UpdateEditIDLE sets the REGISTRY.tcl component into
 # the installed/uninstalled state according to both the
 # Extensions and TclTk features.
- if os.system("nmake /nologo /c /f msisupport.mak") != 0:
- raise "'nmake /f msisupport.mak' failed"
 add_data(db, "Binary", [("Script", msilib.Binary("msisupport.dll"))])
 # See "Custom Action Type 1"
 if msilib.Win64:
-- 
Repository URL: http://hg.python.org/cpython
