[Python-checkins] cpython (2.7): Fix issue #16646: ftplib.FTP.makeport() might lose socket error details.

Mon Dec 17 14:30:58 CET 2012

http://hg.python.org/cpython/rev/6e07be3dfb6b
changeset: 80908:6e07be3dfb6b
branch: 2.7
parent: 80901:542cfc75c043
user: Giampaolo Rodola' <g.rodola at gmail.com>
date: Mon Dec 17 14:30:48 2012 +0100
summary:
 Fix issue #16646: ftplib.FTP.makeport() might lose socket error details. (patch by Serhiy Storchaka)
files:
 Lib/ftplib.py | 11 +++++++----
 Misc/NEWS | 3 +++
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/Lib/ftplib.py b/Lib/ftplib.py
--- a/Lib/ftplib.py
+++ b/Lib/ftplib.py
@@ -273,21 +273,24 @@
 
 def makeport(self):
 '''Create a new socket and send a PORT command for it.'''
- msg = "getaddrinfo returns an empty list"
+ err = None
 sock = None
 for res in socket.getaddrinfo(None, 0, self.af, socket.SOCK_STREAM, 0, socket.AI_PASSIVE):
 af, socktype, proto, canonname, sa = res
 try:
 sock = socket.socket(af, socktype, proto)
 sock.bind(sa)
- except socket.error, msg:
+ except socket.error, err:
 if sock:
 sock.close()
 sock = None
 continue
 break
- if not sock:
- raise socket.error, msg
+ if sock is None:
+ if err is not None:
+ raise err
+ else:
+ raise socket.error("getaddrinfo returns an empty list")
 sock.listen(1)
 port = sock.getsockname()[1] # Get proper port
 host = self.sock.getsockname()[0] # Get proper host
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -160,6 +160,9 @@
 Library
 -------
 
+- Issue #16646: ftplib.FTP.makeport() might lose socket error details.
+ (patch by Serhiy Storchaka)
+
 - Issue #16626: Fix infinite recursion in glob.glob() on Windows when the
 pattern contains a wildcard in the drive or UNC path. Patch by Serhiy
 Storchaka.
-- 
Repository URL: http://hg.python.org/cpython
