[Python-checkins] cpython: Don’t let invalid line in setup.cfg pass silently

Mon Sep 12 17:42:21 CEST 2011

http://hg.python.org/cpython/rev/0f69eb7d5bed
changeset: 72354:0f69eb7d5bed
user: Éric Araujo <merwok at netwok.org>
date: Sat Sep 10 18:22:04 2011 +0200
summary:
 Don’t let invalid line in setup.cfg pass silently
files:
 Lib/packaging/config.py | 7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/Lib/packaging/config.py b/Lib/packaging/config.py
--- a/Lib/packaging/config.py
+++ b/Lib/packaging/config.py
@@ -227,10 +227,11 @@
 self.dist.scripts = [self.dist.scripts]
 
 self.dist.package_data = {}
- for data in files.get('package_data', []):
- data = data.split('=')
+ for line in files.get('package_data', []):
+ data = line.split('=')
 if len(data) != 2:
- continue # FIXME errors should never pass silently
+ raise ValueError('invalid line for package_data: %s '
+ '(misses "=")' % line)
 key, value = data
 self.dist.package_data[key.strip()] = value.strip()
 
-- 
Repository URL: http://hg.python.org/cpython
