[Python-checkins] devguide: More miscellaneous review comments.
ned.deily
python-checkins at python.org
Sun Mar 6 10:37:43 CET 2011
http://hg.python.org/devguide/rev/ad3278cfc5f6
changeset: 376:ad3278cfc5f6
user: Ned Deily <nad at acm.org>
date: Sun Mar 06 01:37:13 2011 -0800
summary:
More miscellaneous review comments.
files:
committing.rst
communication.rst
coredev.rst
faq.rst
stdlibchanges.rst
diff --git a/committing.rst b/committing.rst
--- a/committing.rst
+++ b/committing.rst
@@ -3,6 +3,9 @@
Committing and Pushing Changes
==============================
+.. TODO: include a checklist of items to be included in a commit?
+ e.g updated Misc/NEWS entry, tests, doc
+
Commit Messages
---------------
@@ -11,7 +14,7 @@
developed a standard way of formatting commit messages that everyone is
expected to follow.
-Our usual convention mimicks that used in the ``Misc/NEWS`` file. Actually,
+Our usual convention mimics that used in the ``Misc/NEWS`` file. Actually,
it is common to simply paste the NEWS entry into the commit message. Here
is an example::
diff --git a/communication.rst b/communication.rst
--- a/communication.rst
+++ b/communication.rst
@@ -47,7 +47,9 @@
c.l.py).
A complete list of Python mailing lists can be found at http://mail.python.org.
-Most lists are also mirrored at http://news.gmane.org/.
+Most lists are also mirrored at http://news.gmane.org/ and can be read and
+posted to in various ways, including via web browers, NNTP newsreaders, and
+RSS feed readers.
.. _issue tracker: http://bugs.python.org
.. _new-bugs-announce: http://mail.python.org/mailman/listinfo/new-bugs-announce
diff --git a/coredev.rst b/coredev.rst
--- a/coredev.rst
+++ b/coredev.rst
@@ -6,8 +6,9 @@
What it Takes
-------------
-When you have consistently contributed patches which have met quality standards
-to be committed without requiring extensive rewrites, you may qualify for
+When you have consistently contributed patches which meet quality standards
+without requiring extensive rewrites prior to being committed,
+you may qualify for
commit privileges and become a core developer of Python. You must also work
well with other core developers (and people in general) as you become an
ambassador for the Python project.
@@ -138,8 +139,8 @@
tracker as well.
Third, please list what areas you want to be considered an expert in the
-:ref:`experts`. This allows triagers
-to direct issues your way when they involve an area you are an expert in. But,
+:ref:`experts`. This allows triagers to direct issues to you which involve
+an area you are an expert in. But,
as stated in the second point above, if you do not have the time to answer
questions promptly then please remove yourself as needed from the file so that
you will not be bothered in the future. Once again, we all understand how life
diff --git a/faq.rst b/faq.rst
--- a/faq.rst
+++ b/faq.rst
@@ -609,8 +609,8 @@
.. _PuTTYgen: http://www.chiark.greenend.org.uk/~sgtatham/putty/download.html
-Is there a way to prevent from having to enter my password for my SSH 2 public key constantly?
-------------------------------------------------------------------------------------------------
+Is there a way to avoid having to constantly enter my password for my SSH 2 public key?
+---------------------------------------------------------------------------------------
UNIX
'''''''''''''''''''
diff --git a/stdlibchanges.rst b/stdlibchanges.rst
--- a/stdlibchanges.rst
+++ b/stdlibchanges.rst
@@ -122,7 +122,7 @@
Proposal Process
''''''''''''''''
-If the module you want to proposing adding to the stdlib meets the proper
+If the module you want to propose adding to the stdlib meets the proper
requirements, you may propose its inclusion. To start, you should email
python-list or python-ideas to make sure the community in general would support
the inclusion of the module (see :ref:`communication`).
@@ -141,7 +141,7 @@
When you have listened to, responded, and integrated as appropriate the
feedback from python-ideas into your PEP, you may send it to python-dev. You
will once again receive a large amount of feedback and discussion. A PEP
-dictator will be assigned who make the final call on whether the PEP will be
+dictator will be assigned who makes the final call on whether the PEP will be
accepted or not. If the PEP dictator agrees to accept your PEP (which typically
means that the core developers end up agreeing in general to accepting
your PEP) then the module
--
Repository URL: http://hg.python.org/devguide
More information about the Python-checkins
mailing list