[Python-checkins] cpython (2.7): simply use the Python version for pyexpat.version #12221

Wed Jun 1 02:08:28 CEST 2011

http://hg.python.org/cpython/rev/9c1116e582e3
changeset: 70560:9c1116e582e3
branch: 2.7
user: Benjamin Peterson <benjamin at python.org>
date: Tue May 31 18:59:49 2011 -0500
summary:
 simply use the Python version for pyexpat.__version__ #12221
files:
 Misc/NEWS | 5 +++++
 Modules/pyexpat.c | 26 +++++---------------------
 2 files changed, 10 insertions(+), 21 deletions(-)

diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -7,6 +7,11 @@
 
 *Release date: 2011-06-XX*
 
+Extension Modules
+-----------------
+
+- Issue #1221: Make pyexpat.__version__ equal to the Python version.
+
 
 What's New in Python 2.7.2 release candidate 1?
 ===============================================
diff --git a/Modules/pyexpat.c b/Modules/pyexpat.c
--- a/Modules/pyexpat.c
+++ b/Modules/pyexpat.c
@@ -1792,26 +1792,6 @@
 PyDoc_STRVAR(pyexpat_module_documentation,
 "Python wrapper for Expat parser.");
 
-/* Return a Python string that represents the version number without the
- * extra cruft added by revision control, even if the right options were
- * given to the "cvs export" command to make it not include the extra
- * cruft.
- */
-static PyObject *
-get_version_string(void)
-{
- static char *rcsid = "$Revision$";
- char *rev = rcsid;
- int i = 0;
-
- while (!isdigit(Py_CHARMASK(*rev)))
- ++rev;
- while (rev[i] != ' ' && rev[i] != '0円')
- ++i;
-
- return PyString_FromStringAndSize(rev, i);
-}
-
 /* Initialization function for the module */
 
 #ifndef MODULE_NAME
@@ -1841,6 +1821,7 @@
 PyObject *modelmod_name;
 PyObject *model_module;
 PyObject *sys_modules;
+ PyObject *version;
 static struct PyExpat_CAPI capi;
 PyObject* capi_object;
 
@@ -1872,7 +1853,10 @@
 Py_INCREF(&Xmlparsetype);
 PyModule_AddObject(m, "XMLParserType", (PyObject *) &Xmlparsetype);
 
- PyModule_AddObject(m, "__version__", get_version_string());
+ version = PyString_FromString(PY_VERSION);
+ if (!version)
+ return;
+ PyModule_AddObject(m, "__version__", version);
 PyModule_AddStringConstant(m, "EXPAT_VERSION",
 (char *) XML_ExpatVersion());
 {
-- 
Repository URL: http://hg.python.org/cpython


[Python-checkins] cpython (2.7): simply use the Python version for pyexpat.__version__ #12221

[Python-checkins] cpython (2.7): simply use the Python version for pyexpat.version #12221