[Python-checkins] cpython (3.1): Fix sporadic failure in test_startfile.

Tue Apr 19 02:29:18 CEST 2011

http://hg.python.org/cpython/rev/8b7b3748f876
changeset: 69433:8b7b3748f876
branch: 3.1
parent: 69423:319f7af9ee5e
user: Nadeem Vawda <nadeem.vawda at gmail.com>
date: Tue Apr 19 01:38:47 2011 +0200
summary:
 Fix sporadic failure in test_startfile.
Wait for the child process to terminate before ending the test, so that the
regrtest cleanup code doesn't get an error when it tries to delete the
temporary CWD.
files:
 Lib/test/test_startfile.py | 5 +++++
 Misc/NEWS | 2 ++
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/Lib/test/test_startfile.py b/Lib/test/test_startfile.py
--- a/Lib/test/test_startfile.py
+++ b/Lib/test/test_startfile.py
@@ -11,6 +11,7 @@
 from test import support
 import os
 from os import path
+from time import sleep
 
 startfile = support.get_attribute(os, 'startfile')
 
@@ -23,6 +24,10 @@
 empty = path.join(path.dirname(__file__), "empty.vbs")
 startfile(empty)
 startfile(empty, "open")
+ # Give the child process some time to exit before we finish.
+ # Otherwise the cleanup code will not be able to delete the cwd,
+ # because it is still in use.
+ sleep(0.1)
 
 def test_main():
 support.run_unittest(TestCase)
diff --git a/Misc/NEWS b/Misc/NEWS
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -315,6 +315,8 @@
 Tests
 -----
 
+- Fix test_startfile to wait for child process to terminate before finishing.
+
 - Issue #11719: Fix message about unexpected test_msilib skip on non-Windows
 platforms. Patch by Nadeem Vawda.
 
-- 
Repository URL: http://hg.python.org/cpython
