[Python-checkins] r86450 - in python/branches/py3k: Lib/http/client.py Lib/test/test_httplib.py Misc/NEWS

Sat Nov 13 13:27:49 CET 2010

Author: senthil.kumaran
Date: Sat Nov 13 13:27:49 2010
New Revision: 86450
Log:
Fix Issue5111 - Wrap the Ipv6 host with [] in the Host header
Modified:
 python/branches/py3k/Lib/http/client.py
 python/branches/py3k/Lib/test/test_httplib.py
 python/branches/py3k/Misc/NEWS
Modified: python/branches/py3k/Lib/http/client.py
==============================================================================

--- python/branches/py3k/Lib/http/client.py	(original)
+++ python/branches/py3k/Lib/http/client.py	Sat Nov 13 13:27:49 2010
@@ -874,6 +874,13 @@
 host_enc = self.host.encode("ascii")
 except UnicodeEncodeError:
 host_enc = self.host.encode("idna")
+
+ # As per RFC 273, IPv6 address should be wrapped with []
+ # when used as Host header
+
+ if self.host.find(':') >= 0:
+ host_enc = b'[' + host_enc + b']'
+
 if self.port == self.default_port:
 self.putheader('Host', host_enc)
 else:
Modified: python/branches/py3k/Lib/test/test_httplib.py
==============================================================================
--- python/branches/py3k/Lib/test/test_httplib.py	(original)
+++ python/branches/py3k/Lib/test/test_httplib.py	Sat Nov 13 13:27:49 2010
@@ -106,6 +106,25 @@
 conn.putheader('Content-length', 42)
 self.assertTrue(b'Content-length: 42' in conn._buffer)
 
+ def test_ipv6host_header(self):
+ # Default host header on IPv6 transaction should wrapped by [] if
+ # its actual IPv6 address
+ expected = b'GET /foo HTTP/1.1\r\nHost: [2001::]:81\r\n' \
+ b'Accept-Encoding: identity\r\n\r\n'
+ conn = client.HTTPConnection('[2001::]:81')
+ sock = FakeSocket('')
+ conn.sock = sock
+ conn.request('GET', '/foo')
+ self.assertTrue(sock.data.startswith(expected))
+
+ expected = b'GET /foo HTTP/1.1\r\nHost: [2001:102A::]\r\n' \
+ b'Accept-Encoding: identity\r\n\r\n'
+ conn = client.HTTPConnection('[2001:102A::]')
+ sock = FakeSocket('')
+ conn.sock = sock
+ conn.request('GET', '/foo')
+ self.assertTrue(sock.data.startswith(expected))
+
 
 class BasicTest(TestCase):
 def test_status_lines(self):
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Sat Nov 13 13:27:49 2010
@@ -63,6 +63,8 @@
 Library
 -------
 
+- Issue #5111: IPv6 Host in the Header is wrapped inside [ ]. Patch by Chandru.
+
 - Fix Fraction.__hash__ so that Fraction.__hash__(-1) is -2. (See
 also issue #10356.)
 
