[Python-checkins] r81454 - in python/trunk: Lib/test/test_multibytecodec.py Misc/NEWS Modules/cjkcodecs/multibytecodec.c

Sat May 22 00:50:29 CEST 2010

Author: victor.stinner
Date: Sat May 22 00:50:28 2010
New Revision: 81454
Log:
Issue #5640: Fix Shift-JIS incremental encoder for error handlers different
than strict
Modified:
 python/trunk/Lib/test/test_multibytecodec.py
 python/trunk/Misc/NEWS
 python/trunk/Modules/cjkcodecs/multibytecodec.c
Modified: python/trunk/Lib/test/test_multibytecodec.py
==============================================================================

--- python/trunk/Lib/test/test_multibytecodec.py	(original)
+++ python/trunk/Lib/test/test_multibytecodec.py	Sat May 22 00:50:28 2010
@@ -107,6 +107,10 @@
 self.assertRaises(UnicodeEncodeError, encoder.encode, u'\u0123')
 self.assertEqual(encoder.encode(u'', True), '\xa9\xdc')
 
+ def test_issue5640(self):
+ encoder = codecs.getincrementalencoder('shift-jis')('backslashreplace')
+ self.assertEqual(encoder.encode(u'\xff'), b'\\xff')
+ self.assertEqual(encoder.encode(u'\n'), b'\n')
 
 class Test_IncrementalDecoder(unittest.TestCase):
 
Modified: python/trunk/Misc/NEWS
==============================================================================
--- python/trunk/Misc/NEWS	(original)
+++ python/trunk/Misc/NEWS	Sat May 22 00:50:28 2010
@@ -29,6 +29,9 @@
 Library
 -------
 
+- Issue #5640: Fix Shift-JIS incremental encoder for error handlers different
+ than strict
+
 - Issue #8782: Add a trailing newline in linecache.updatecache to the last line
 of files without one.
 
Modified: python/trunk/Modules/cjkcodecs/multibytecodec.c
==============================================================================
--- python/trunk/Modules/cjkcodecs/multibytecodec.c	(original)
+++ python/trunk/Modules/cjkcodecs/multibytecodec.c	Sat May 22 00:50:28 2010
@@ -498,7 +498,6 @@
 outleft = (Py_ssize_t)(buf.outbuf_end - buf.outbuf);
 r = codec->encode(state, codec->config, &buf.inbuf, inleft,
 &buf.outbuf, outleft, flags);
- *data = buf.inbuf;
 if ((r == 0) || (r == MBERR_TOOFEW && !(flags & MBENC_FLUSH)))
 break;
 else if (multibytecodec_encerror(codec, state, &buf, errors,r))
@@ -528,6 +527,7 @@
 if (_PyString_Resize(&buf.outobj, finalsize) == -1)
 goto errorexit;
 
+	*data = buf.inbuf;
 Py_XDECREF(buf.excobj);
 return buf.outobj;
 
