[Python-checkins] r79393 - in python/branches/py3k: Lib/test/test_sys.py Misc/NEWS Python/bltinmodule.c

Thu Mar 25 01:30:29 CET 2010

Author: victor.stinner
Date: Thu Mar 25 01:30:28 2010
New Revision: 79393
Log:
Issue #8226: sys.setfilesystemencoding() raises a LookupError if the encoding
is unknown.
Modified:
 python/branches/py3k/Lib/test/test_sys.py
 python/branches/py3k/Misc/NEWS
 python/branches/py3k/Python/bltinmodule.c
Modified: python/branches/py3k/Lib/test/test_sys.py
==============================================================================

--- python/branches/py3k/Lib/test/test_sys.py	(original)
+++ python/branches/py3k/Lib/test/test_sys.py	Thu Mar 25 01:30:28 2010
@@ -799,6 +799,7 @@
 old = sys.getfilesystemencoding()
 sys.setfilesystemencoding("iso-8859-1")
 self.assertEqual(sys.getfilesystemencoding(), "iso-8859-1")
+ self.assertRaises(LookupError, sys.setfilesystemencoding, "xxx")
 sys.setfilesystemencoding(old)
 
 def test_main():
Modified: python/branches/py3k/Misc/NEWS
==============================================================================
--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Thu Mar 25 01:30:28 2010
@@ -12,6 +12,9 @@
 Core and Builtins
 -----------------
 
+- Issue #8226: sys.setfilesystemencoding() raises a LookupError if the encoding
+ is unknown
+
 - Issue #1583863: An str subclass can now override the __str__ method
 
 - Issue #8014: Setting a T_UINT or T_PYSSIZET attribute of an object with
Modified: python/branches/py3k/Python/bltinmodule.c
==============================================================================
--- python/branches/py3k/Python/bltinmodule.c	(original)
+++ python/branches/py3k/Python/bltinmodule.c	Thu Mar 25 01:30:28 2010
@@ -29,7 +29,7 @@
 int
 _Py_SetFileSystemEncoding(PyObject *s)
 {
-	PyObject *defenc;
+	PyObject *defenc, *codec;
 	if (!PyUnicode_Check(s)) {
 		PyErr_BadInternalCall();
 		return -1;
@@ -37,6 +37,10 @@
 	defenc = _PyUnicode_AsDefaultEncodedString(s, NULL);
 	if (!defenc)
 		return -1;
+	codec = _PyCodec_Lookup(PyBytes_AsString(defenc));
+	if (codec == NULL)
+		return -1;
+	Py_DECREF(codec);
 	if (!Py_HasFileSystemDefaultEncoding && Py_FileSystemDefaultEncoding)
 		/* A file system encoding was set at run-time */
 		free((char*)Py_FileSystemDefaultEncoding);
