[Python-checkins] r75967 - python/trunk/Lib/test/test_pydoc.py

Fri Oct 30 22:41:22 CET 2009

Author: antoine.pitrou
Date: Fri Oct 30 22:41:22 2009
New Revision: 75967
Log:
Try to fix transient refleaks in test_pydoc.
Modified:
 python/trunk/Lib/test/test_pydoc.py
Modified: python/trunk/Lib/test/test_pydoc.py
==============================================================================

--- python/trunk/Lib/test/test_pydoc.py	(original)
+++ python/trunk/Lib/test/test_pydoc.py	Fri Oct 30 22:41:22 2009
@@ -9,7 +9,8 @@
 import unittest
 import test.test_support
 from contextlib import contextmanager
-from test.test_support import TESTFN, forget, rmtree, EnvironmentVarGuard
+from test.test_support import (
+ TESTFN, forget, rmtree, EnvironmentVarGuard, reap_children)
 
 from test import pydoc_mod
 
@@ -178,8 +179,11 @@
 output of pydoc.
 """
 cmd = [sys.executable, pydoc.__file__, " ".join(args), module_name]
- output = subprocess.Popen(cmd, stdout=subprocess.PIPE).stdout.read()
- return output.strip()
+ try:
+ output = subprocess.Popen(cmd, stdout=subprocess.PIPE).communicate()[0]
+ return output.strip()
+ finally:
+ reap_children()
 
 def get_pydoc_html(module):
 "Returns pydoc generated output as html"
