[Python-checkins] r70099 - in python/branches/py3k: Doc/library/importlib.rstLib/importlib/NOTES Lib/importlib/test/test_util.py Lib/importlib/util.py

Wed Mar 4 17:07:28 CET 2009

On Wed, Mar 4, 2009 at 03:58, Nick Coghlan <ncoghlan at gmail.com> wrote:
> Brett Cannon wrote:
> >
> >
> > On Mon, Mar 2, 2009 at 07:06, Antoine Pitrou <solipsis at pitrou.net
> > <mailto:solipsis at pitrou.net>> wrote:
> >
> > <brett.cannon> writes:
> > >
> > > Log:
> > > Expose importlib.util.set___package__.
> >
> > I'm not sure there's an underscore run-length restriction in PEP8,
> > but what
> > about simply naming it set_package ? :-)
> >
> >
> > It's more descriptive. =) I don't know, I have a slight worry someone
> > will misunderstand what the decorator does if I just say 'set_package'.
> > Anyone else have an opinion?
>> I'd say lose the extra underscores - anyone that can figure out the
> import system well enough to write their own module loader isn't going
> to be confused about what @set_package does just because they only have
> to type 1 underscore instead of 4 :)
>
OK, you two convinced me: changed in 70163.
-Brett
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-checkins/attachments/20090304/1c6b11f4/attachment.htm>