[Python-checkins] r73788 - in python/branches/py3k: Misc/NEWS setup.py

Fri Jul 3 01:08:45 CEST 2009

Author: amaury.forgeotdarc
Date: Fri Jul 3 01:08:45 2009
New Revision: 73788
Log:
#4601: 'make install' did not set the permissions on library directories,
only root could start IDLE for example.
Beware that os.path.walk does not translate as is to os.walk!
the former uses a callback to call on each dir, the latter is a generator...
Modified:
 python/branches/py3k/Misc/NEWS
 python/branches/py3k/setup.py
Modified: python/branches/py3k/Misc/NEWS
==============================================================================

--- python/branches/py3k/Misc/NEWS	(original)
+++ python/branches/py3k/Misc/NEWS	Fri Jul 3 01:08:45 2009
@@ -41,6 +41,9 @@
 Build
 -----
 
+- Issue 4601: 'make install' did not set the appropriate permissions on
+ directories.
+
 - Issue 5390: Add uninstall icon independent of whether file
 extensions are installed.
 
Modified: python/branches/py3k/setup.py
==============================================================================
--- python/branches/py3k/setup.py	(original)
+++ python/branches/py3k/setup.py	Fri Jul 3 01:08:45 2009
@@ -1605,12 +1605,11 @@
 
 def set_dir_modes(self, dirname, mode):
 if not self.is_chmod_supported(): return
- os.walk(dirname, self.set_dir_modes_visitor, mode)
-
- def set_dir_modes_visitor(self, mode, dirname, names):
- if os.path.islink(dirname): return
- log.info("changing mode of %s to %o", dirname, mode)
- if not self.dry_run: os.chmod(dirname, mode)
+ for dirpath, dirnames, fnames in os.walk(dirname):
+ if os.path.islink(dirpath):
+ continue
+ log.info("changing mode of %s to %o", dirpath, mode)
+ if not self.dry_run: os.chmod(dirpath, mode)
 
 def is_chmod_supported(self):
 return hasattr(os, 'chmod')
