[Python-checkins] r69551 - python/trunk/Lib/distutils/tests/test_build_ext.py

Fri Feb 13 17:38:17 CET 2009

On Fri, Feb 13, 2009 at 4:52 PM, Amaury Forgeot d'Arc
<amauryfa at gmail.com> wrote:
> On Thu, Feb 12, 2009 at 23:48, Tarek Ziadé <ziade.tarek at gmail.com> wrote:
>> I have just seen that someone else fixed the leak here when I was
>> merging my fix in py3k
>>>> http://bugs.python.org/issue4373
>>>> I came up with another fix, shown below. I think my patch is simpler,
>>>> I'd like to :
>>>> - change the one in py3k so it is similar
>> - add Amaury's explanation in setUp
>>>> Opinions ?
>> Your patch seems to reuse the same file on every iteration. Will it
> works on Windows?

The only part where I might fail on Windows is when shutil.rmtree is called,
so it's not the right way, thanks for the feedback.
I have reverted that,
> And, isn't __file__ referring to the python Lib directory? It is not
> always writable.
>
Usually, I write temporary files for tests inside the tests folder,
os.path.dirname(__file__) in that case refers to the tests dir.
Does it mean we might run the tests on a Python installation where
this folder might not be writable ?
If so, I need to change that practice
> --
> Amaury Forgeot d'Arc
>
-- 
Tarek Ziadé | Association AfPy | www.afpy.org
Blog FR | http://programmation-python.org
Blog EN | http://tarekziade.wordpress.com/