[Python-checkins] r53484 - python/branches/release25-maint/Modules/_ctypes/_ctypes.c

Thu Jan 18 08:16:32 CET 2007

Author: neal.norwitz
Date: Thu Jan 18 08:16:31 2007
New Revision: 53484
Modified:
 python/branches/release25-maint/Modules/_ctypes/_ctypes.c
Log:
Add a comment for some code I don't understand. Why would needsfree
be true if we didn't malloc the code? Seems like the code is wrong
or could use comments.
Also verify if the buildbots are working properly for the 2.5 branch.
Modified: python/branches/release25-maint/Modules/_ctypes/_ctypes.c
==============================================================================

--- python/branches/release25-maint/Modules/_ctypes/_ctypes.c	(original)
+++ python/branches/release25-maint/Modules/_ctypes/_ctypes.c	Thu Jan 18 08:16:31 2007
@@ -2199,6 +2199,7 @@
 	if ((size_t)dict->size <= sizeof(obj->b_value)) {
 		/* No need to call malloc, can use the default buffer */
 		obj->b_ptr = (char *)&obj->b_value;
+		/* XXX(nnorwitz): shouldn't b_needsfree be 0? */
 		obj->b_needsfree = 1;
 	} else {
 		/* In python 2.4, and ctypes 0.9.6, the malloc call took about
