[Python-checkins] r51857 - in python/branches/release25-maint: Misc/NEWS Python/pystate.c

Mon Sep 11 10:51:18 CEST 2006

Author: neal.norwitz
Date: Mon Sep 11 10:51:17 2006
New Revision: 51857
Modified:
 python/branches/release25-maint/Misc/NEWS
 python/branches/release25-maint/Python/pystate.c
Log:
Building with HP's cc on HP-UX turned up a couple of problems.
_PyGILState_NoteThreadState was declared as static inconsistently.
Make it static as it's not necessary outside of this module.
Some tests failed because errno was reset to 0. (I think the tests
that failed were at least: test_fcntl and test_mailbox).
Ensure that errno doesn't change after a call to Py_END_ALLOW_THREADS.
This only affected debug builds.
This needs to be ported to HEAD. I'll try to remember to do that tomorrow.
(Anyone, feel free to port it.)
Modified: python/branches/release25-maint/Misc/NEWS
==============================================================================

--- python/branches/release25-maint/Misc/NEWS	(original)
+++ python/branches/release25-maint/Misc/NEWS	Mon Sep 11 10:51:17 2006
@@ -19,6 +19,9 @@
 Core and builtins
 -----------------
 
+- Make _PyGILState_NoteThreadState() static, it was not used anywhere
+ outside of pystate.c and should not be necessary.
+
 - Bug #1551432: Exceptions do not define an explicit __unicode__ method. This
 allows calling unicode() on exceptions classes directly to succeed.
 
Modified: python/branches/release25-maint/Python/pystate.c
==============================================================================
--- python/branches/release25-maint/Python/pystate.c	(original)
+++ python/branches/release25-maint/Python/pystate.c	Mon Sep 11 10:51:17 2006
@@ -309,9 +309,14 @@
 	*/
 #if defined(Py_DEBUG) && defined(WITH_THREAD)
 	if (newts) {
+		/* This can be called from PyEval_RestoreThread(). Similar
+		 to it, we need to ensure errno doesn't change.
+		*/
+		int err = errno;
 		PyThreadState *check = PyGILState_GetThisThreadState();
 		if (check && check->interp == newts->interp && check != newts)
 			Py_FatalError("Invalid thread state for this thread");
+		errno = err;
 	}
 #endif
 	return oldts;
@@ -504,7 +509,7 @@
 it so it doesn't try to create another thread state for the thread (this is
 a better fix for SF bug #1010677 than the first one attempted).
 */
-void
+static void
 _PyGILState_NoteThreadState(PyThreadState* tstate)
 {
 	/* If autoTLSkey is 0, this must be the very first threadstate created
