[Python-checkins] r42818 - python/trunk/Lib/test/test_logging.py

Fri Mar 3 22:53:14 CET 2006

Author: neal.norwitz
Date: Fri Mar 3 22:53:14 2006
New Revision: 42818
Modified:
 python/trunk/Lib/test/test_logging.py
Log:
I think the test_logging failure on Solaris is timing related. We don't
want to wait forever if we don't receive the last message. But we also
don't want the test to fail if we shutdown too quickly. I can't reliably
reproduce this failure, so I'm kinda guessing this is the problem.
We'll see if this band-aid helps.
Modified: python/trunk/Lib/test/test_logging.py
==============================================================================

--- python/trunk/Lib/test/test_logging.py	(original)
+++ python/trunk/Lib/test/test_logging.py	Fri Mar 3 22:53:14 2006
@@ -98,13 +98,22 @@
 self.abort = 0
 self.timeout = 1
 
+ def _wait_and_process_data(self):
+ rd, wr, ex = select.select([self.socket.fileno()], [], [],
+ self.timeout)
+ if rd:
+ self.handle_request()
+
 def serve_until_stopped(self):
 while not self.abort:
- rd, wr, ex = select.select([self.socket.fileno()],
- [], [],
- self.timeout)
- if rd:
- self.handle_request()
+ self._wait_and_process_data()
+
+ # XXX(nnorwitz): Try to fix timing related test failures.
+ # It's possible self.aborted was set before the final message
+ # was received. By calling _wait_and_process_data(),
+ # it gives us one last chance to read messages.
+ # The test generally only fails on Solaris.
+ self._wait_and_process_data()
 #notify the main thread that we're about to exit
 socketDataProcessed.set()
 # close the listen socket
