[Python-checkins] r46603 - python/trunk/Lib/test/test_struct.py

Sun Jun 4 15:44:49 CEST 2006

On 6/3/06, Tim Peters <tim.peters at gmail.com> wrote:
> >>> Author: martin.blais
> >>> Date: Fri Jun 2 15:03:43 2006
> >>> New Revision: 46603
> >>>
> >>> Modified:
> >>> python/trunk/Lib/test/test_struct.py
> >>> Log:
> >>> Fixed struct test to not use unittest.
>> [Neal Norwitz]
> >> Shoot, I had hoped you would go the other way and convert all the old
> >> test cases to use unittest. :-)
>> [Thomas Wouters]
> > Heh, my reaction was both "huh?" and "yay" at the same time. I thought
> > unittest was still preferred for the stdlib testsuite?
>> That or doctest. What's definitely unwanted now is the original style
> of test that compares the whole test's output to an expected-output
> file in Lib/test/output/. Those can be horrid to figure out when they
> go wrong, and don't check at all when running regrtest with -v.

I looked at the existing tests, I did not observe consistency, so I
took the path of minimal effort.
If you really care, then I suggest you should all agree on something,
and then someone should show courage and convert all the existing
tests to that thing (ideally, someone who cares). I would be happy to
comply with whatever thing you choose to agree on.
cheers,